From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933132AbcIUOPl (ORCPT ); Wed, 21 Sep 2016 10:15:41 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:38005 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932385AbcIUOPk (ORCPT ); Wed, 21 Sep 2016 10:15:40 -0400 Date: Wed, 21 Sep 2016 07:15:39 -0700 From: Christoph Hellwig To: Jonathan Nicklin Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: BUG: aio/direct-io data corruption in 4.7 Message-ID: <20160921141539.GA17898@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jonathan, please keep linux-fsdevel on the Cc list for something like, and if you already track down a commit the author of that commit. > Description: "fs: simplify the generic_write_sync prototype" > Committed: Apr 7, 2016 > Hash: e259221763a40403d5bb232209998e8c45804ab8 > Affects: 4.7-rc1 - master > > I have confirmed a fix for the AIO/Direct-IO failure condition but > have not reviewed the rest of the changes associated with that commit. > If you would like a small patch for direct-io.c, let me know. On travel right now, but I suspect you want something like this fix? diff --git a/fs/direct-io.c b/fs/direct-io.c index 7c3ce73..891f71f 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c @@ -276,7 +276,7 @@ static ssize_t dio_complete(struct dio *dio, ssize_t ret, bool is_async) dio->iocb->ki_pos += transferred; if (dio->op == REQ_OP_WRITE) - ret = generic_write_sync(dio->iocb, transferred); + ret = generic_write_sync(dio->iocb, ret); dio->iocb->ki_complete(dio->iocb, ret, 0); }