* [PATCH] rcu: add missing prototype
@ 2016-09-20 16:32 Eric Engestrom
2016-09-21 18:48 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: Eric Engestrom @ 2016-09-20 16:32 UTC (permalink / raw)
To: linux-kernel; +Cc: Eric Engestrom, Paul E. McKenney, Josh Triplett
`make W=1` warns:
kernel/rcu/tree.c:226:15: warning: no previous prototype for ‘rcu_rnp_online_cpus’ [-Wmissing-prototypes]
unsigned long rcu_rnp_online_cpus(struct rcu_node *rnp)
^~~~~~~~~~~~~~~~~~~
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
I couldn't figure out how this list is ordered, I'm happy to move this
line if you want :)
---
kernel/rcu/tree.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h
index f714f87..23be3dc 100644
--- a/kernel/rcu/tree.h
+++ b/kernel/rcu/tree.h
@@ -668,6 +668,7 @@ static void rcu_sysidle_init_percpu_data(struct rcu_dynticks *rdtp);
static bool rcu_nohz_full_cpu(struct rcu_state *rsp);
static void rcu_dynticks_task_enter(void);
static void rcu_dynticks_task_exit(void);
+static unsigned long rcu_rnp_online_cpus(struct rcu_node *rnp);
#endif /* #ifndef RCU_TREE_NONCORE */
--
Cheers,
Eric
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rcu: add missing prototype
2016-09-20 16:32 [PATCH] rcu: add missing prototype Eric Engestrom
@ 2016-09-21 18:48 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2016-09-21 18:48 UTC (permalink / raw)
To: Eric Engestrom; +Cc: linux-kernel, Josh Triplett
On Tue, Sep 20, 2016 at 05:32:59PM +0100, Eric Engestrom wrote:
> `make W=1` warns:
> kernel/rcu/tree.c:226:15: warning: no previous prototype for ‘rcu_rnp_online_cpus’ [-Wmissing-prototypes]
> unsigned long rcu_rnp_online_cpus(struct rcu_node *rnp)
> ^~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
You lost me on this one. It seems to be complaining about the initial
definition.
Hmmm... Would making this function static __maybe_unused also resolve this?
Thanx, Paul
> ---
>
> I couldn't figure out how this list is ordered, I'm happy to move this
> line if you want :)
>
> ---
> kernel/rcu/tree.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h
> index f714f87..23be3dc 100644
> --- a/kernel/rcu/tree.h
> +++ b/kernel/rcu/tree.h
> @@ -668,6 +668,7 @@ static void rcu_sysidle_init_percpu_data(struct rcu_dynticks *rdtp);
> static bool rcu_nohz_full_cpu(struct rcu_state *rsp);
> static void rcu_dynticks_task_enter(void);
> static void rcu_dynticks_task_exit(void);
> +static unsigned long rcu_rnp_online_cpus(struct rcu_node *rnp);
>
> #endif /* #ifndef RCU_TREE_NONCORE */
>
> --
> Cheers,
> Eric
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-21 18:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-20 16:32 [PATCH] rcu: add missing prototype Eric Engestrom
2016-09-21 18:48 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox