From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938555AbcIUSwL (ORCPT ); Wed, 21 Sep 2016 14:52:11 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:40518 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933013AbcIUSwK (ORCPT ); Wed, 21 Sep 2016 14:52:10 -0400 Date: Wed, 21 Sep 2016 11:48:40 -0700 From: "Paul E. McKenney" To: Eric Engestrom Cc: linux-kernel@vger.kernel.org, Josh Triplett Subject: Re: [PATCH] rcu: add missing prototype Reply-To: paulmck@linux.vnet.ibm.com References: <20160920163259.5566-1-eric.engestrom@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160920163259.5566-1-eric.engestrom@imgtec.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16092118-0028-0000-0000-000005A81B92 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005798; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000185; SDB=6.00759945; UDB=6.00361383; IPR=6.00534375; BA=6.00004744; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012742; XFM=3.00000011; UTC=2016-09-21 18:52:08 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16092118-0029-0000-0000-00002F6EE4D2 Message-Id: <20160921184840.GD10850@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-21_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609020000 definitions=main-1609210341 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 20, 2016 at 05:32:59PM +0100, Eric Engestrom wrote: > `make W=1` warns: > kernel/rcu/tree.c:226:15: warning: no previous prototype for ‘rcu_rnp_online_cpus’ [-Wmissing-prototypes] > unsigned long rcu_rnp_online_cpus(struct rcu_node *rnp) > ^~~~~~~~~~~~~~~~~~~ > > Signed-off-by: Eric Engestrom You lost me on this one. It seems to be complaining about the initial definition. Hmmm... Would making this function static __maybe_unused also resolve this? Thanx, Paul > --- > > I couldn't figure out how this list is ordered, I'm happy to move this > line if you want :) > > --- > kernel/rcu/tree.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h > index f714f87..23be3dc 100644 > --- a/kernel/rcu/tree.h > +++ b/kernel/rcu/tree.h > @@ -668,6 +668,7 @@ static void rcu_sysidle_init_percpu_data(struct rcu_dynticks *rdtp); > static bool rcu_nohz_full_cpu(struct rcu_state *rsp); > static void rcu_dynticks_task_enter(void); > static void rcu_dynticks_task_exit(void); > +static unsigned long rcu_rnp_online_cpus(struct rcu_node *rnp); > > #endif /* #ifndef RCU_TREE_NONCORE */ > > -- > Cheers, > Eric >