From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934093AbcIUUrb (ORCPT ); Wed, 21 Sep 2016 16:47:31 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:49938 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933255AbcIUUr3 (ORCPT ); Wed, 21 Sep 2016 16:47:29 -0400 Date: Wed, 21 Sep 2016 15:46:35 -0500 From: Bin Liu To: Arnd Bergmann CC: Greg Kroah-Hartman , David Lechner , , Subject: Re: [PATCH] usb: musb: fix error handling message in probe Message-ID: <20160921204635.GB3981@uda0271908> Mail-Followup-To: Bin Liu , Arnd Bergmann , Greg Kroah-Hartman , David Lechner , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20160916222153.1023842-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160916222153.1023842-1-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sat, Sep 17, 2016 at 12:21:25AM +0200, Arnd Bergmann wrote: > We print an error message when platform_device_register_full() > fails, but the initialization of the argument has been removed, > as shown in this warning: > > drivers/usb/musb/da8xx.c: In function 'da8xx_probe': > drivers/usb/musb/da8xx.c:521:3: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > This modifies the function to assign the return code before > checking it, and does uses the same method in the check for > usb_phy_generic_register() as well. > > Fixes: 947c49afe41f ("usb: musb: da8xx: Remove mach code") > Signed-off-by: Arnd Bergmann Applied. Thanks. (Added 'da8xx:' prefix in the commit subject) Regards, -Bin.