From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935215AbcIUVDq (ORCPT ); Wed, 21 Sep 2016 17:03:46 -0400 Received: from down.free-electrons.com ([37.187.137.238]:42865 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935104AbcIUVDn (ORCPT ); Wed, 21 Sep 2016 17:03:43 -0400 Date: Thu, 22 Sep 2016 00:03:40 +0300 From: Maxime Ripard To: Jonathan Liu Cc: David Airlie , Chen-Yu Tsai , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/sun4i: rgb: Enable panel after controller Message-ID: <20160921210340.GI8719@lukather> References: <20160921130304.3486-1-net147@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Dp1s8ZelCQsTdIdV" Content-Disposition: inline In-Reply-To: <20160921130304.3486-1-net147@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Dp1s8ZelCQsTdIdV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Wed, Sep 21, 2016 at 11:03:04PM +1000, Jonathan Liu wrote: > The panel should be enabled after the controller so that the panel > prepare/enable delays are properly taken into account. Similarly, the > panel should be disabled before the controller so that the panel > unprepare/disable delays are properly taken into account. > > This is useful for avoiding visual glitches. This is not really taking any delays into account, especially since drm_panel_enable and prepare are suppose to block until their operation is complete. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --Dp1s8ZelCQsTdIdV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJX4vWsAAoJEBx+YmzsjxAgDA8P/31EgIEiWNn0zxn3bP3hGVc4 eGJX/EVagJS6KfOauFyqa1YLHCs2TlUCSB3MDBQnqPfqpC8FzNkzyfPpEcAcCRD9 IOYptuQbBWrq/a1qEBBrpz6nCvizKSJbGNCVmQPp5BcCJtLxddchji4D+rmSQu5l /PGxDow9j+tt1J8LCLYa9m8gNvNOMhs1lvTzx0wwDGzZlYyXjqN3UTq3DNmyxXHC DlrK4+ZYuQUB64j+DS1WtQMiA+I/7ic/s6w0No5FANYdCVTKBrczxMjffcPln7HO PytzfMJQV2dzxsz1EEOKXXVtMx6iR6ZNA2wCf+ySeg8d7btiEo9Pn/8f4dFb81gE lMT6FgrmH6/iF44fsGP6sruYQZhxde+nTz+gp6i6fE74dADRJS3/CvJud5vj/tL4 B+JLQuV+zf3FWCbMXnu5HMK0GVaZCFojXg6/utNGSDtukRIBBNG/XxjYV5Kvkmud WufQKyhkUaOd2oghDnkalrehi/R7aDLKu6YXvp+fe8LNkjObeMnMRfVPhuIoFZ7m 17Km3ACOT9JUV9re8atVO6GV9/e8q944pbJefUrxMdWX9mJtn+IfsnCgP7wjojJV 6iN4O5Okim6wYrw4IVmU9r+uUJuNhjh4A6OUWYJ02FGW2etXJDFAAnsFnydY8UnT rsgExLfCAiAIjKG/VU90 =veqI -----END PGP SIGNATURE----- --Dp1s8ZelCQsTdIdV--