From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933128AbcIVG53 (ORCPT ); Thu, 22 Sep 2016 02:57:29 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:57146 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932916AbcIVG51 (ORCPT ); Thu, 22 Sep 2016 02:57:27 -0400 Date: Thu, 22 Sep 2016 08:57:32 +0200 From: Greg Kroah-Hartman To: Sumit Semwal Cc: Gustavo Padovan , Baoyou Xie , Arnd Bergmann , xie.baoyou@zte.com.cn, LKML , DRI mailing list , Linaro MM SIG Mailman List , "linux-media@vger.kernel.org" Subject: Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static Message-ID: <20160922065731.GA16298@kroah.com> References: <1474202961-10099-1-git-send-email-baoyou.xie@linaro.org> <20160920111338.GE13275@joana> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 20, 2016 at 06:23:33PM +0530, Sumit Semwal wrote: > Hi Baoyou, > > On 20 September 2016 at 16:43, Gustavo Padovan wrote: > > 2016-09-18 Baoyou Xie : > > > >> We get 1 warning when building kernel with W=1: > >> drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes] > >> > >> In fact, this function is only used in the file in which it is > >> declared and don't need a declaration, but can be made static. > >> So this patch marks it 'static'. > >> > >> Signed-off-by: Baoyou Xie > >> --- > >> drivers/dma-buf/sw_sync.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Thanks for finding this. > > Thanks for the patch; this doesn't apply to mainline yet, since the > de-staging of sw_sync code is queued for 4.9 via Greg-KH's tree. > CC'ing him. > > Greg, would it be possible to please take this via your tree? If someone resends it to me with the needed acks and reviewed-by, I will. thanks, greg k-h