From: Peter Zijlstra <peterz@infradead.org>
To: Christoffer Dall <christoffer.dall@linaro.org>
Cc: Marc Zyngier <marc.zyngier@arm.com>,
linux-kernel@vger.kernel.org, Jason Baron <jbaron@akamai.com>,
Jonathan Corbet <corbet@lwn.net>,
Vladimir Murzin <vladimir.murzin@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH 1/2] jump_labels: Add API to deal with keys embedded in structures
Date: Thu, 22 Sep 2016 09:47:37 +0200 [thread overview]
Message-ID: <20160922074737.GU5008@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20160920125401.GB16763@cbox>
On Tue, Sep 20, 2016 at 02:54:01PM +0200, Christoffer Dall wrote:
> On Tue, Sep 20, 2016 at 02:42:58PM +0200, Peter Zijlstra wrote:
> > 'struct static_key' should indeed not be used and is deprecated. 'struct
> > static_key_{true,false}' however should be fine.
>
> ah, ok, didn't realize this, especially since static_key_false() is also
> listed as deprecated ;)
Yeah, that's one of the horribly badly named things we wants to get rid
of :-) But note, its a function not a type.
> > Part of the problem is naming, everything using 'struct static_key' has
> > _insane_ names and the API is utterly confusing. The other part is that
> > the new 2 type API simply has more functionality.
>
> right, ok. As long as you're happy with slightly increased use of
> directly embeddeing struct static_key_{true,false}, we're good.
>
> Sorry for both if I encouraged confusion here.
No problem, jump_labels have been cursed with confusion.
next prev parent reply other threads:[~2016-09-22 7:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 17:21 [PATCH 0/2] jump_labels: Embedding static keys inside structures Marc Zyngier
2016-09-19 17:21 ` [PATCH 1/2] jump_labels: Add API to deal with keys embedded in structures Marc Zyngier
2016-09-20 9:42 ` Peter Zijlstra
2016-09-20 9:46 ` Marc Zyngier
2016-09-20 12:25 ` Christoffer Dall
2016-09-20 12:42 ` Peter Zijlstra
2016-09-20 12:54 ` Christoffer Dall
2016-09-22 7:47 ` Peter Zijlstra [this message]
2016-09-19 17:21 ` [PATCH 2/2] dynamic_debug: Use updated jump label API Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160922074737.GU5008@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=corbet@lwn.net \
--cc=jbaron@akamai.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=vladimir.murzin@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox