From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753520AbcIVHrp (ORCPT <rfc822;w@1wt.eu>);
        Thu, 22 Sep 2016 03:47:45 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:47549 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751095AbcIVHro (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 22 Sep 2016 03:47:44 -0400
Date: Thu, 22 Sep 2016 09:47:37 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Christoffer Dall <christoffer.dall@linaro.org>
Cc: Marc Zyngier <marc.zyngier@arm.com>, linux-kernel@vger.kernel.org,
        Jason Baron <jbaron@akamai.com>, Jonathan Corbet <corbet@lwn.net>,
        Vladimir Murzin <vladimir.murzin@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH 1/2] jump_labels: Add API to deal with keys embedded in
 structures
Message-ID: <20160922074737.GU5008@twins.programming.kicks-ass.net>
References: <1474305688-22553-1-git-send-email-marc.zyngier@arm.com>
 <1474305688-22553-2-git-send-email-marc.zyngier@arm.com>
 <20160920094223.GR5012@twins.programming.kicks-ass.net>
 <20160920122514.GA16763@cbox>
 <20160920124258.GU5012@twins.programming.kicks-ass.net>
 <20160920125401.GB16763@cbox>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160920125401.GB16763@cbox>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 20, 2016 at 02:54:01PM +0200, Christoffer Dall wrote:
> On Tue, Sep 20, 2016 at 02:42:58PM +0200, Peter Zijlstra wrote:
> > 'struct static_key' should indeed not be used and is deprecated. 'struct
> > static_key_{true,false}' however should be fine.
> 
> ah, ok, didn't realize this, especially since static_key_false() is also
> listed as deprecated ;)

Yeah, that's one of the horribly badly named things we wants to get rid
of :-) But note, its a function not a type.


> > Part of the problem is naming, everything using 'struct static_key' has
> > _insane_ names and the API is utterly confusing. The other part is that
> > the new 2 type API simply has more functionality.
> 
> right, ok.  As long as you're happy with slightly increased use of
> directly embeddeing struct static_key_{true,false}, we're good.
> 
> Sorry for both if I encouraged confusion here.

No problem, jump_labels have been cursed with confusion.