From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933478AbcIVIyO (ORCPT <rfc822;w@1wt.eu>);
        Thu, 22 Sep 2016 04:54:14 -0400
Received: from merlin.infradead.org ([205.233.59.134]:44744 "EHLO
        merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932375AbcIVIyM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 22 Sep 2016 04:54:12 -0400
Date: Thu, 22 Sep 2016 10:54:06 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Jiri Olsa <jolsa@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>, David Ahern <dsahern@gmail.com>
Subject: Re: failed to add c++ probe
Message-ID: <20160922085406.GY5008@twins.programming.kicks-ass.net>
References: <20160919095402.GA2306@krava>
 <20160920080557.5db69ddd16524ca6abcb3d83@kernel.org>
 <alpine.DEB.2.20.1609200129550.5524@nanos>
 <20160921123759.5c3f1f5db5f298a20ea784b0@kernel.org>
 <20160921134324.996aae22bead9dbf34a7a41d@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160921134324.996aae22bead9dbf34a7a41d@kernel.org>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 21, 2016 at 01:43:24PM +0900, Masami Hiramatsu wrote:
> On Wed, 21 Sep 2016 12:37:59 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:

> Hmm, I found there are 3 issues in perf-probe to define event on C++ libs.
> 
> 1) No mangle/demangle symbol support. This needs a) fix option parser to
>    accept C++ method name correctly, b) mangle that method, and c) demangle
>    it when we show the probe point.

I think we should also allow using the mangled name, supporting (de)mangling
is of course nice, but not required per-se. Esp. since there's more than
just C++ mangling. Having the mangling stuff as optional makes it a
convenience but still allows using this on other languages for which we
do not support the mangling.

> 2) @plt symbol should be skipped since the real function will be called(jumped)
>    from plt, when searching probe point.
> 
> 3) Event group name is including some characters which can not be used (e.g. "++").
>    Thus we have to remove it or replace it with '_' or other alphabet.("PP"?)

What is the problem with the '+' character? Why cannot this be used?