From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756698AbcIVJ2D (ORCPT ); Thu, 22 Sep 2016 05:28:03 -0400 Received: from mx2.suse.de ([195.135.220.15]:32790 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753183AbcIVJ2A (ORCPT ); Thu, 22 Sep 2016 05:28:00 -0400 Date: Thu, 22 Sep 2016 11:27:58 +0200 From: Jean Delvare To: Jonathan Corbet Cc: LKML , linux-doc@vger.kernel.org, Christian Borntraeger Subject: Re: [PATCH] docs: Remove space-before-label guidance from CodingStyle Message-ID: <20160922112758.6fbfeffe@endymion> In-Reply-To: <20160921155401.7acd5a47@lwn.net> References: <20160921155401.7acd5a47@lwn.net> Organization: SUSE Linux X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.30; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jonathan, On Wed, 21 Sep 2016 15:54:01 -0600, Jonathan Corbet wrote: > Recent discussion has made it clear that there is no community consensus > on this particular rule. Remove it now, lest it inspire yet another set > of unwanted "cleanup" patches. > > This partially reverts 865a1caa4b6b (CodingStyle: Clarify and complete > chapter 7). > (...) > @@ -481,7 +478,7 @@ The rationale for using gotos is: > goto out_buffer; > } > ... > - out_free_buffer: > + out_free_buffer: > kfree(buffer); > return result; > } > @@ -490,7 +487,7 @@ A common type of bug to be aware of is ``one err > bugs`` which look like this: > .. code-block:: c > > - err: > + err: > kfree(foo->bar); > kfree(foo); > return ret; There are 2 more occurrences after this point, which you probably want to change too. -- Jean Delvare SUSE L3 Support