From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933466AbcIVQkg (ORCPT ); Thu, 22 Sep 2016 12:40:36 -0400 Received: from mail-sn1nam01on0082.outbound.protection.outlook.com ([104.47.32.82]:18064 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750868AbcIVQkd (ORCPT ); Thu, 22 Sep 2016 12:40:33 -0400 X-Greylist: delayed 1907 seconds by postgrey-1.27 at vger.kernel.org; Thu, 22 Sep 2016 12:40:32 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jan.Glauber@cavium.com; Date: Thu, 22 Sep 2016 18:40:18 +0200 From: Jan Glauber To: Wolfram Sang CC: , , "Bazhenov, Dmitry" Subject: Re: [PATCH 5/5] i2c: octeon,thunderx: Limit register access retries Message-ID: <20160922164018.GA2993@hardcore> References: <20160921210335.GG1513@katana> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160921210335.GG1513@katana> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [46.223.65.126] X-ClientProxiedBy: VI1PR0101CA0037.eurprd01.prod.exchangelabs.com (10.166.38.47) To BN3PR07MB2578.namprd07.prod.outlook.com (10.167.5.6) X-MS-Office365-Filtering-Correlation-Id: 999b1eb7-70f4-4653-0f4c-08d3e3072a5d X-Microsoft-Exchange-Diagnostics: 1;BN3PR07MB2578;2:SbxwdfsJUspGPav3NbgyB9czlvA5XdkhmL/dn1gBD0qY8pIbWCEwRkaV5/guxXMWIcBHppVAFcaqbDXBLAP7wFIGPmYs82/ff4lYPQVNLFa4ca6UgeuAssV/0hrbXXUlpbzJvYb3paFN3oO6sg8cue0FWz8SdYUou6icFznpdvbFx43PdM7wvHk6qIE9vKKN;3:6l0bfOCo2MxTmpIgZPfiAJYHAS21ePYs1TBTT2em+omejTS750pPip0pex4omQeQirsTrzJZfeeI3x59X9fTTarP0ROLIJLtZ97AoL/YWrwd8lA8HfBSxQVSQE87Ew47;25:WLVgMq6W+9JLCrFEIJ4q6XKJEFt7qBuHqIehLWIPtjgEDp6m/90XdgJNjuJ2JzxPt6DH0rCPGEEKxZqc/z8XThzFeK2qKpZEy+h4eJD/Qzh2OMIsahFhrUh4Eg2YDdv1XKrMIRH6Klxo1mz5tL80Is/1nV27jwCY1QEOmil7xKVfIjvUQSOzDqROaonuu7nSXQx1DI4ZXJ+FG9jJl/nzMTHFb3ZCZHVsyjsGdM+fqp17FQydTTg5StUbJo1faaziwtScKXGi+gPYM4tYIX0fEee7zvC4U72Nsws7uaqqiVf+7SUC7n+cLeaOfzSaIC6pBanijwX4J++hTa+jEheFFMDrYR2yjeDHLI5t+cjy8S77t9TCwUhprKIkwzUmqO229cqiuMPNbHG0xOoLOOPdDy7uMoEkgNAq3lV42hPvl8M= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR07MB2578; X-Microsoft-Exchange-Diagnostics: 1;BN3PR07MB2578;31:SJU2/IbbOhFeCjlytbcowx8ipRA7AHmbrxMOqWRL6jMphII9B5JNuIL/PcuHikqAM7DlznK79VdzA/5r+6No2yHZAV3EAFQsj+w5J0Jf3XZnL1bklJTmHylmrgyUB4OgUymJ/O8pHL9MhbYuB3FxzmHGzbvzpds9VcJjM4F8PZmD5PHJ9Ld1QjOZ1WXW8BKhGb7n2StuCVJO4swyd1PyzL5LCdvQ1+xEO/+yIt6N8Os=;20:Ssfh2w98r0+O1GDKqJIZkzyWhp6z1iQTqc2TfIMhIwME1nZKtR0wD4fJEB6grfCGuWooZQwqX3R1AQ/zzPq0jCG4ac2R3Z7sXp5Po+sQsAc0F2FZYqvzZS0r/dHymxb0tVvR5Zz0sGkg/hWWIkDj+11wY5f/157vbDRIUyDCvaWbK45dVGBbPJqVqxoMK86DCBKSiUJsDIOK+mQacW3w1QgT8YAK9+p81Y0+UB5a3BkFihWVME2L470eAPgaeTJqfHpvKW/hZ3GOM7gYDi8tqxmU2n0EDWfOS70GP16vbpEfScakvPB1A6wnVX6rDE2QQxwXAtJL7vh0HfOlJ+HLd4yq7MfYICK84MhCJ5UpUWwibeopjF8kkMte7qk7v1sRiurISLNX2kxiJbvdB/IZ4fkkbzc+ifcCHNLads3xisAgAvfE7oDA9mDiCkQfYlMsYuX1yl2jYVhP4eX6rFUJEXbv9sWALeue1jtBJPeXekTMOLuzPSCN7fredE4nCasTU8uqZPTU6jZaTwXDaoDhjtTINTUs5sRf0+JCUy4KGxUYKGwvTYB9cvzK20cvCVJ98erHndD30j3Sb9VU55IDUSWuNLRpwMQVwFVXLb5NVqo= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:BN3PR07MB2578;BCL:0;PCL:0;RULEID:;SRVR:BN3PR07MB2578; X-Microsoft-Exchange-Diagnostics: 1;BN3PR07MB2578;4:Ky0gDEyJe0BsoFofzYuELXMGU4s3/ft/vhcAgedTMpuM7RqcqppQAnAjQqtclV1j2XtPBL53RvPMm+YbtJDjl6uFJALZ1omLtwN7R2FoN4YHPb84g/wsBHHkAxNCJKiBlOzH/L/pEvraHP8Kkg0e2TGlfzkZ2n7gvFRDkG1BU110nLqEkB5LBVKdRL5p1lLYITP8VUJ525UE6p/zAl/WqG6AnNMz4qKG8ZPhODMELJxN679rmK1Fh8oW+Mho51t9RV71lK+M3s/W2gb2o7dbhVm4yfblwulAayoXktGsiX9YApFY/WDNJ5Oo1+1duGzhiKlWizaSOqEyRZA4xpCYTNTIy4ErjRZWzLEfQtxDBJqT/I9vCqO/a2E5saImyEqy X-Forefront-PRVS: 0073BFEF03 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(199003)(24454002)(2906002)(33656002)(42186005)(19580405001)(4326007)(19580395003)(81166006)(6116002)(81156014)(47776003)(66066001)(33716001)(105586002)(3846002)(106356001)(23726003)(1076002)(8676002)(83506001)(189998001)(7736002)(54356999)(68736007)(586003)(50466002)(97756001)(305945005)(46406003)(101416001)(92566002)(2950100001)(4001350100001)(5660300001)(76176999)(50986999)(97736004)(110136003)(77096005)(7846002)(9686002)(18370500001)(142933001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR07MB2578;H:hardcore;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN3PR07MB2578;23:JEMk14CH7TUwPKFtqhsp0BQzujKsRWFOpiCRgF4DD?= =?us-ascii?Q?HhoowMo2BPkQv0bCVjvc4S6CFxBnOrNJOQXlhy5qp/Mx8ODANevw30VKUocC?= =?us-ascii?Q?WgOIzP3UUrNyBu4Zcfm0oyIZe/eiPyfd1mWUdQVRucfkDXK4y/A62Chc5BvG?= =?us-ascii?Q?2FZCSavabbbBRPh1Ua2rOQWuG9rLKLXIu3c+D09qtNlRqRsXCuqV3awp38lc?= =?us-ascii?Q?rYHMNgtHQqqkEs/HXpDzbc9XKqXLEhL9OK+DqPP2/AhBZLnRP3T+2M7/OY/f?= =?us-ascii?Q?pITMoJ0WNbSP+2dn51aRNHuUeJzEaPKOPc6qCDgQdx4MSt8AbWDIEPMU911x?= =?us-ascii?Q?uBVcYtP30TOZEJCD9i9zjOnGxz37f4l3hsH0ftigzVoCA6zFS6dkSbrrYsxL?= =?us-ascii?Q?vsrp0YcyPjjJtj1781wpLylekJyx2sr9G/RuW2RmYzISHNOToW5U62DVUuXu?= =?us-ascii?Q?o4ApErJbS0ONnxHDnQPnxNzVYE7bStDiXtNdrPV6vnnVBm1lZRUAVw2xz9oM?= =?us-ascii?Q?mHJkON4p97hP0HWfvAVv4cv7LofYfNGrsUskjX5rojRJgwwKSeZMdcQMcxCJ?= =?us-ascii?Q?tQSOL1ELMAqreleyAKYFPI6SkEcALN+dLIWVUdV9M5jQgjRAOsA+nqSVIdF7?= =?us-ascii?Q?cZPyzrJh+5/1Cu/AZoCcqP4HGviW/81y1mb3wX7PWR9af4KxFuqeZJ9P5X1e?= =?us-ascii?Q?Q7u0WgI3EX3LxtidFBmFOlr4u/77uFXbD9WYUExCzpj++gBnQ3B+k38DhcGy?= =?us-ascii?Q?AaF6bXVXXT34IbcXT45DIZB4QtMgjMO4Mms8w8dAOb4NZPR/50rAzOf2no4U?= =?us-ascii?Q?OGubNdBzVhBY0YgZbxnByaebvnYXMWdaqds2gYCgHqpe5Ycvznq9IaydEQrh?= =?us-ascii?Q?2K7rqOz5hSRf3P4qqsU5liLftZUTZN/zUrVlHRq08vHHdqHTNwYMCHOnGyyg?= =?us-ascii?Q?Dnh8H2R/XqHQr72cjZSDPysz39j7cGvUcjtypsAml9PRb57oriyJ6IyqjVDG?= =?us-ascii?Q?7ApAEFusWsFwnXapgglkP6bsJo/qIW+iX7YsCjL4iCAKOWGPx2mnFdlBPC2q?= =?us-ascii?Q?CCc0IZa6vhzanTz7xgxADUf5M8ylIiGIkIIrj0Ks+qbipk4CfMeVN48zqfUx?= =?us-ascii?Q?wll4SlqP2IHs4BZlHNzE66+G4opDpyHOn7nOJz4RZyX53GfrD+9wriSjLuDT?= =?us-ascii?Q?xQ9bNGEINXKstO3kqxnKU3zK0alutCAYa1R?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR07MB2578;6:f92treen3yPqcvPl2f7m0iYBWYLWTAAlVOas8TYc2WMozL9K0M2E2oH0N6dBGG/NH9eGWpewUPa+s9cxHWEFb+QiWZukUxySAdJGuD19xRoWIKS9+rKDM+BTSGw5PvHXiVFOOyElsxUE59YNHxRb4voHthkC9vbyKru22sSoRsyO+VadUgJV8zpm1WhQo1hvHcZTKSThHqri3h0GujN73zeCoXA4vvV5Ij/ATJhg/1sjHtQEk4KYRsakKcbInETvgRt60X5aX1i6gngxLJB/C09RYvpS08XK01zF2kVYulg=;5:zwgowyanJ3g8qLao5Tla7ZUmnhTeHP23HFSYovFxL1rodOBR2YD0CgejKUonzn0ljNjX74T87G23jsxoOa9GLKem386qDZTGTgCIPmP9wyj2DFQjdWwo6caTkV7t84UhFRW7x1frZEX6H5aZb8zQlg==;24:2nF6EU5GzhrdWv7o2KooMqt1ZdeUy8d/r0u29HaZ3sTezKnD5AtuYSL1s2YSHjpFL6Sg4NKFqUA4FrXR1v784etDRwY0v61mnFu3AYGGRNk=;7:6VXN6KBGPXMh7lvtrldq01pgJaHvXlfcaIwBLoMWnFQH7ahsn66CnZPDH9MiyIsNrNEVuAoSz7abMrFHgWzOmNdGbh6P4TGJLFbyPLKnH6YTdNGYEIky3TfpYZIyp9HHVIaBUdPVLx8PjZ5Nb9g2mjOGVNGp2qcEAO0ysd9vnVaRGHbjQhel2mKNQ6Nx8+XxcKkSjkBOBBd65dQ8HI1dCbcHgkIuyRpycZavtKE/uFF7mDD0ojXpkWKB5MLY9OT4XNGpr9t1AjbsoJ5JWZAJymwJ8cKu0kVyBeAySk6UGuPN5ckTZZMdB1ZRa8dscn9q SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2016 16:40:29.5422 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2578 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 21, 2016 at 11:03:35PM +0200, Wolfram Sang wrote: > On Wed, Sep 21, 2016 at 08:51:06AM +0200, Jan Glauber wrote: > > Do not infinitely retry register readq and writeq operations > > in order to not lock up the CPU in case the TWSI gets stuck. > > > > Return -EIO in case of a failed data read. For all other > > cases just return so subsequent operations will fail > > and trigger the recovery. > > > > Signed-off-by: Jan Glauber > > I didn't really check, but have you considered using > readq_poll_timeout() from iopoll.h? > Indeed, readq_poll_timeout() fits quite well here. It will lose some cycles on mips but I'm not convinced that matters with i2c. That would be the first user of readq_poll_timeout() in the kernel :) --Jan