From: Keith Busch <keith.busch@intel.com>
To: J Freyensee <james_p_freyensee@linux.intel.com>
Cc: Jens Axboe <axboe@fb.com>, Andy Lutomirski <luto@amacapital.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-nvme@lists.infradead.org, Andy Lutomirski <luto@kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v4 0/3] nvme power saving
Date: Thu, 22 Sep 2016 18:16:14 -0400 [thread overview]
Message-ID: <20160922221613.GC14301@keith> (raw)
In-Reply-To: <1474580016.15303.31.camel@linux.intel.com>
On Thu, Sep 22, 2016 at 02:33:36PM -0700, J Freyensee wrote:
> ...and some SSDs don't even support this feature yet, so the number of
> different NVMe devices available to test initially will most likely be
> small (like the Fultondales I have, all I could check is to see if the
> code broke anything if the device did not have this power-save
> feature).
>
> I agree with Jens, makes a lot of sense to start with this feature
> 'off'.
>
> To 'advertise' the feature, maybe make the feature a new selection in
> Kconfig? Example, initially make it "EXPERIMENTAL", and later when
> more devices implement this feature it can be integrated more tightly
> into the NVMe solution and default to on.
Should we just leave the kernel out of this then? I bet we could script
this feature in user space.
next prev parent reply other threads:[~2016-09-22 22:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 18:16 [PATCH v4 0/3] nvme power saving Andy Lutomirski
2016-09-16 18:16 ` [PATCH v4 1/3] nvme/scsi: Remove power management support Andy Lutomirski
2016-09-16 23:37 ` J Freyensee
2016-09-16 18:16 ` [PATCH v4 2/3] nvme: Pass pointers, not dma addresses, to nvme_get/set_features() Andy Lutomirski
2016-09-16 18:16 ` [PATCH v4 3/3] nvme: Enable autonomous power state transitions Andy Lutomirski
2016-09-17 0:49 ` [PATCH v4 0/3] nvme power saving J Freyensee
2016-09-22 0:11 ` Andy Lutomirski
2016-09-22 13:21 ` Christoph Hellwig
2016-09-22 14:23 ` Jens Axboe
2016-09-22 20:11 ` Andy Lutomirski
2016-09-22 20:43 ` Jens Axboe
2016-09-22 21:33 ` J Freyensee
2016-09-22 22:15 ` Andy Lutomirski
2016-10-28 0:06 ` Andy Lutomirski
2016-10-28 5:29 ` Christoph Hellwig
2016-09-22 22:16 ` Keith Busch [this message]
2016-09-22 22:07 ` Jens Axboe
2016-09-23 23:42 ` Christoph Hellwig
2016-09-24 16:55 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160922221613.GC14301@keith \
--to=keith.busch@intel.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=james_p_freyensee@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox