From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936473AbcIWMnD (ORCPT ); Fri, 23 Sep 2016 08:43:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36174 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1034323AbcIWMmx (ORCPT ); Fri, 23 Sep 2016 08:42:53 -0400 Date: Fri, 23 Sep 2016 08:42:51 -0400 From: Mike Snitzer To: Peter Zijlstra Cc: Mike Galbraith , Thomas Gleixner , Mikulas Patocka , Alasdair Kergon , Ingo Molnar , linux-kernel@vger.kernel.org, dm-devel@redhat.com, Joe Thornber Subject: Re: [RFC][PATCH] dm: Remove dm_bufio_cond_resched() Message-ID: <20160923124251.GA22428@redhat.com> References: <20160913084520.GA5012@twins.programming.kicks-ass.net> <20160913133959.GA22833@redhat.com> <20160919105325.GW5016@twins.programming.kicks-ass.net> <20160923073435.GL2794@worktop> <1474633030.4025.11.camel@gmail.com> <20160923122607.GK5008@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160923122607.GK5008@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 23 Sep 2016 12:42:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 23 2016 at 8:26am -0400, Peter Zijlstra wrote: > On Fri, Sep 23, 2016 at 02:17:10PM +0200, Mike Galbraith wrote: > > On Fri, 2016-09-23 at 10:00 +0200, Thomas Gleixner wrote: > > > On Fri, 23 Sep 2016, Peter Zijlstra wrote: > > > > > > Is anybody still using PREEMPT_NONE? Most workloads also care about > > > > latency to some extend. Lots of code has explicit cond_resched() and > > > > doesn't worry. > > > > > > Dunno. But I bet there are workloads which love it. > > > > SUSE definitely uses it. I had presumed that was enterprise standard. > > Hmm, I thought most distros defaulted to PREEMPT_VOLUNTARY. So what is the concensus on this? Switch dm-bufio's cond_resched calls (in peter's patch) to might_sleep()? Or continue using cond_resched but fix cond_resched to do the might_sleep() equivalent if PREEMPT_NONE? Mike