Re: [PATCH 0/5] ACPI / gpio: Updates to properties

Mika Westerberg
2016-09-29T07:00:34Z

On Wed, Sep 28, 2016 at 11:32:46PM +0200, Rafael J. Wysocki wrote:
> Hi,
>
> On Fri, Sep 23, 2016 at 4:57 PM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> > Hi,
> >
> > This series brings couple of useful GPIO related properties from Device
> > Tree to ACPI _DSD device properties:
> >
> > - Names for GPIO lines
> > - GPIO hogging
> > - Holes in GPIO property lists
> >
> > We are using these to get Intel Galileo better supported in the mainline
> > kernel (but these may be useful for other boards as well). For example SPI
> > chip select on Galileo is connected to a GPIO line so we need to be able to
> > describe it in ACPI, and at the same time allow native chip selects.
> >
> > GPIO hogging can be used to set initial state of certain GPIOs available on
> > the headers regardless of the BIOS settings (which may be wrong as it knows
> > nothing about which devices have been connected).
> >
> > Mika Westerberg (5):
> > ACPI / documentation: Use recommended name in GPIO property names
> > ACPI / gpio: Add support for naming GPIOs
> > ACPI / gpio: Add hogging support
> > ACPI / property: Allow holes in reference properties
> > ACPI / gpio: Allow holes in list of GPIOs for a device
> >
> > Documentation/acpi/gpio-properties.txt | 72 ++++++++++++++--
> > drivers/acpi/property.c | 116 +++++++++++++++++++-------
> > drivers/gpio/gpiolib-acpi.c | 147 ++++++++++++++++++++++++++++++---
> > include/linux/acpi.h | 3 +
> > 4 files changed, 292 insertions(+), 46 deletions(-)
>
> I would like to tackle patches [1/5] and [4/5] first, as they are core
> patches and the rest is against gpiolib-acpi.

Works for me.

I can re-arrange the series so that the two core patches (1,4/5) are
first and then the GPIO parts.

> Moreover, the documentation patch [1/5] looks like immediately applicable to me.

Yes, it just fixes the names to match what is preferred.