From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: [PATCH 1/5] ACPI / documentation: Use recommended name in GPIO property names
Date: Fri, 23 Sep 2016 17:57:06 +0300 [thread overview]
Message-ID: <20160923145710.105489-2-mika.westerberg@linux.intel.com> (raw)
In-Reply-To: <20160923145710.105489-1-mika.westerberg@linux.intel.com>
The recommended property name for all kinds of GPIOs is to end it with
"-gpios" even if there is only one GPIO. Update the documentation to follow
this fact.
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
Documentation/acpi/gpio-properties.txt | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/Documentation/acpi/gpio-properties.txt b/Documentation/acpi/gpio-properties.txt
index f35dad11f0de..5aafe0b351a1 100644
--- a/Documentation/acpi/gpio-properties.txt
+++ b/Documentation/acpi/gpio-properties.txt
@@ -28,8 +28,8 @@ index, like the ASL example below shows:
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package ()
{
- Package () {"reset-gpio", Package() {^BTH, 1, 1, 0 }},
- Package () {"shutdown-gpio", Package() {^BTH, 0, 0, 0 }},
+ Package () {"reset-gpios", Package() {^BTH, 1, 1, 0 }},
+ Package () {"shutdown-gpios", Package() {^BTH, 0, 0, 0 }},
}
})
}
@@ -48,7 +48,7 @@ Since ACPI GpioIo() resource does not have a field saying whether it is
active low or high, the "active_low" argument can be used here. Setting
it to 1 marks the GPIO as active low.
-In our Bluetooth example the "reset-gpio" refers to the second GpioIo()
+In our Bluetooth example the "reset-gpios" refers to the second GpioIo()
resource, second pin in that resource with the GPIO number of 31.
ACPI GPIO Mappings Provided by Drivers
@@ -83,8 +83,8 @@ static const struct acpi_gpio_params reset_gpio = { 1, 1, false };
static const struct acpi_gpio_params shutdown_gpio = { 0, 0, false };
static const struct acpi_gpio_mapping bluetooth_acpi_gpios[] = {
- { "reset-gpio", &reset_gpio, 1 },
- { "shutdown-gpio", &shutdown_gpio, 1 },
+ { "reset-gpios", &reset_gpio, 1 },
+ { "shutdown-gpios", &shutdown_gpio, 1 },
{ },
};
--
2.9.3
next prev parent reply other threads:[~2016-09-23 14:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 14:57 [PATCH 0/5] ACPI / gpio: Updates to properties Mika Westerberg
2016-09-23 14:57 ` Mika Westerberg [this message]
2016-09-23 14:57 ` [PATCH 2/5] ACPI / gpio: Add support for naming GPIOs Mika Westerberg
2016-09-23 14:57 ` [PATCH 3/5] ACPI / gpio: Add hogging support Mika Westerberg
2016-09-23 14:57 ` [PATCH 4/5] ACPI / property: Allow holes in reference properties Mika Westerberg
2016-09-28 21:36 ` Rafael J. Wysocki
2016-09-29 6:48 ` Mika Westerberg
2016-09-29 11:53 ` Rafael J. Wysocki
2016-09-29 11:56 ` Mika Westerberg
2016-09-29 12:33 ` Rafael J. Wysocki
2016-09-23 14:57 ` [PATCH 5/5] ACPI / gpio: Allow holes in list of GPIOs for a device Mika Westerberg
2016-09-28 21:32 ` [PATCH 0/5] ACPI / gpio: Updates to properties Rafael J. Wysocki
2016-09-29 7:00 ` Mika Westerberg
2016-09-29 12:26 ` Rafael J. Wysocki
2016-10-19 12:41 ` Mika Westerberg
2016-10-19 21:22 ` Rafael J. Wysocki
2016-10-20 7:46 ` Mika Westerberg
2016-10-20 12:17 ` Linus Walleij
2016-10-20 12:35 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923145710.105489-2-mika.westerberg@linux.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox