From: Greg KH <gregkh@linuxfoundation.org>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: mathias.nyman@intel.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, arnd@arndb.de,
xie.baoyou@linaro.org, xie.baoyou@zte.com.cn
Subject: Re: [PATCH] usb: xhci: mark xhci_unmap_td_bounce_buffer() static
Date: Fri, 23 Sep 2016 17:08:37 +0200 [thread overview]
Message-ID: <20160923150837.GC13933@kroah.com> (raw)
In-Reply-To: <1474638373-27342-1-git-send-email-baoyou.xie@linaro.org>
On Fri, Sep 23, 2016 at 09:46:13PM +0800, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/usb/host/xhci-ring.c:608:6: warning: no previous prototype for 'xhci_unmap_td_bounce_buffer' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> so this patch marks this function with 'static'.
Any reason you aren't using sparse for all of these 'static' functions
you are finding? It should be easier than using 'W=1'.
thanks,
greg k-h
next prev parent reply other threads:[~2016-09-23 15:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 13:46 [PATCH] usb: xhci: mark xhci_unmap_td_bounce_buffer() static Baoyou Xie
2016-09-23 15:08 ` Greg KH [this message]
2016-09-23 16:02 ` Arnd Bergmann
2016-09-26 9:59 ` Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923150837.GC13933@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=xie.baoyou@linaro.org \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).