From: Greg KH <gregkh@linuxfoundation.org>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: wsa@the-dreams.de, bhumirks@gmail.com, dan.carpenter@oracle.com,
julia.lawall@lip6.fr, weiyongjun1@huawei.com,
karniksayli1995@gmail.com, devel@driverdev.osuosl.org,
xie.baoyou@zte.com.cn, linux-kernel@vger.kernel.org,
arnd@arndb.de
Subject: Re: [PATCH 1/2] Staging: ks7010: mark symbols static where possible
Date: Fri, 23 Sep 2016 19:10:20 +0200 [thread overview]
Message-ID: <20160923171020.GA28694@kroah.com> (raw)
In-Reply-To: <1474636949-10297-1-git-send-email-baoyou.xie@linaro.org>
On Fri, Sep 23, 2016 at 09:22:29PM +0800, Baoyou Xie wrote:
> We get 3 warnings when building kernel with W=1:
> drivers/staging/ks7010/ks7010_sdio.c:90:6: warning: no previous prototype for 'ks_wlan_hw_sleep_doze_request' [-Wmissing-prototypes]
> drivers/staging/ks7010/ks7010_sdio.c:120:6: warning: no previous prototype for 'ks_wlan_hw_sleep_wakeup_request' [-Wmissing-prototypes]
> drivers/staging/ks7010/ks7010_sdio.c:172:5: warning: no previous prototype for '_ks_wlan_hw_power_save' [-Wmissing-prototypes]
>
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> so this patch marks these functions with 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
> drivers/staging/ks7010/ks7010_sdio.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Does not apply cleanly, are you sure you are using the latest tree?
Can you fix it up and resend?
thanks,
greg k-h
next prev parent reply other threads:[~2016-09-23 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 13:22 [PATCH 1/2] Staging: ks7010: mark symbols static where possible Baoyou Xie
2016-09-23 17:10 ` Greg KH [this message]
[not found] ` <CA+DQWkzFtEpnJn1L0sj6bdaEb8PLe0D9usu8ixy5N7U4ztm_2w@mail.gmail.com>
2016-09-24 9:14 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923171020.GA28694@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=bhumirks@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=julia.lawall@lip6.fr \
--cc=karniksayli1995@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
--cc=wsa@the-dreams.de \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox