From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759456AbcIWRKQ (ORCPT ); Fri, 23 Sep 2016 13:10:16 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39882 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754127AbcIWRKP (ORCPT ); Fri, 23 Sep 2016 13:10:15 -0400 Date: Fri, 23 Sep 2016 19:10:20 +0200 From: Greg KH To: Baoyou Xie Cc: wsa@the-dreams.de, bhumirks@gmail.com, dan.carpenter@oracle.com, julia.lawall@lip6.fr, weiyongjun1@huawei.com, karniksayli1995@gmail.com, devel@driverdev.osuosl.org, xie.baoyou@zte.com.cn, linux-kernel@vger.kernel.org, arnd@arndb.de Subject: Re: [PATCH 1/2] Staging: ks7010: mark symbols static where possible Message-ID: <20160923171020.GA28694@kroah.com> References: <1474636949-10297-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474636949-10297-1-git-send-email-baoyou.xie@linaro.org> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 23, 2016 at 09:22:29PM +0800, Baoyou Xie wrote: > We get 3 warnings when building kernel with W=1: > drivers/staging/ks7010/ks7010_sdio.c:90:6: warning: no previous prototype for 'ks_wlan_hw_sleep_doze_request' [-Wmissing-prototypes] > drivers/staging/ks7010/ks7010_sdio.c:120:6: warning: no previous prototype for 'ks_wlan_hw_sleep_wakeup_request' [-Wmissing-prototypes] > drivers/staging/ks7010/ks7010_sdio.c:172:5: warning: no previous prototype for '_ks_wlan_hw_power_save' [-Wmissing-prototypes] > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > so this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie > --- > drivers/staging/ks7010/ks7010_sdio.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Does not apply cleanly, are you sure you are using the latest tree? Can you fix it up and resend? thanks, greg k-h