From: Bjorn Helgaas <helgaas@kernel.org>
To: Keith Busch <keith.busch@intel.com>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv3 2/2] x86/vmd: Add PCI domain specific LED option
Date: Fri, 23 Sep 2016 14:12:23 -0500 [thread overview]
Message-ID: <20160923191223.GA16019@localhost> (raw)
In-Reply-To: <20160923165702.GA20686@keith>
On Fri, Sep 23, 2016 at 12:57:02PM -0400, Keith Busch wrote:
> On Fri, Sep 23, 2016 at 09:34:41AM -0500, Bjorn Helgaas wrote:
> > I made the necessary changes to match the renaming I did in the first
> > patch, and I also used plain old "#ifdef" instead of "#if IS_ENABLED"
> > since the rest of the file uses the former style. If there's a reason
> > to switch, we should change the whole file in a separate patch so we
> > can explain the rationale.
>
> The check was "IS_ENABLED" because VMD can be a loadable module, which
> fails the ifdef check. I see Fengguang 0'dayed it using the module
> configuration option. I can send you a fix based on your pci/hotplug
> branch, or revert and apply the original patch if you prefer.
I didn't realize VMD could be a loadable module, and I didn't realize
that would make a difference for the config symbol.
BTW, the "Volume Management Device Driver" config item appears by
itself in the top-level menuconfig menu. That seems a little ...
presumptuous; is it what you intended?
It took me a while, but I did eventually figure out why #ifdef doesn't
work -- we generate a different include/generated/autoconf.h symbol
for modules:
built-in loadable module
--------------------- ---------------------------
.config CONFIG_VMD=y CONFIG_VMD=m
autoconf.h #define CONFIG_VMD 1 #define CONFIG_VMD_MODULE 1
Anyway, I fixed it by using IS_ENABLED() again.
I might propose a comment update to help anybody else who stumbles
over this. It was kind of annoying to puzzle this out.
> BTW, you had asked me not to split a series when incremental fixes
> touched a single patch. I didn't resend the whole series here, and while
> you got the right patches, I apologize for making it more difficult to find.
No problem, I was just paying more attention this time :)
Except for IS_ENABLED(), anyway.
Bjorn
next prev parent reply other threads:[~2016-09-23 19:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 15:05 [PATCHv3 1/2] pciehp: Let user control LED status Keith Busch
2016-09-13 15:05 ` [PATCHv3 2/2] x86/vmd: Add PCI domain specific LED option Keith Busch
2016-09-23 14:34 ` Bjorn Helgaas
2016-09-23 16:57 ` Keith Busch
2016-09-23 19:12 ` Bjorn Helgaas [this message]
2016-09-23 22:14 ` Keith Busch
2024-07-25 17:36 ` Bjorn Helgaas
2016-09-13 15:28 ` [PATCHv3 1/2] pciehp: Let user control LED status kbuild test robot
2016-09-13 16:36 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923191223.GA16019@localhost \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox