From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034494AbcIWTrd (ORCPT ); Fri, 23 Sep 2016 15:47:33 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:33275 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965693AbcIWTrb (ORCPT ); Fri, 23 Sep 2016 15:47:31 -0400 Date: Fri, 23 Sep 2016 14:47:28 -0500 From: Rob Herring To: Fabien Lahoudere Cc: Peter.Chen@nxp.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/2] usb: chipidea: imx: Add binding to disable USB 60Mhz clock Message-ID: <20160923194728.GA7120@rob-hp-laptop> References: <1474448827-8354-1-git-send-email-fabien.lahoudere@collabora.co.uk> <1474448827-8354-3-git-send-email-fabien.lahoudere@collabora.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474448827-8354-3-git-send-email-fabien.lahoudere@collabora.co.uk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 21, 2016 at 11:07:07AM +0200, Fabien Lahoudere wrote: > This binding allow to disable the internal 60Mhz clock for USB host2 or > host3. > > Signed-off-by: Fabien Lahoudere > --- > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 + > drivers/usb/chipidea/ci_hdrc_imx.c | 2 ++ > drivers/usb/chipidea/ci_hdrc_imx.h | 1 + > drivers/usb/chipidea/usbmisc_imx.c | 13 +++++++++++++ > 4 files changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > index 0e03344..f83da66 100644 > --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > @@ -84,6 +84,7 @@ i.mx specific properties > - over-current-active-high: over current signal polarity is high active, > typically over current signal polarity is low active. > - external-vbus-divider: enables off-chip resistor divider for Vbus > +- disable-int60ck: disable internal 60MHz clock for usb host2 or host3 on imx53 Doesn't this depend on something else like the type of phy connected? If not, when can you do this or not? Rob