Re: [PATCH] f2fs: remove dirty inode pages in error path

Chao Yu
2016-09-26T01:04:45Z

On 2016/9/25 1:47, Jaegeuk Kim wrote:
> On Sat, Sep 24, 2016 at 09:02:02AM +0800, Chao Yu wrote:
>> On 2016/9/24 5:11, Jaegeuk Kim wrote:
>>> When getting EIO while handling orphan inodes, we can get some dirty node
>>> pages. Then, f2fs_write_node_pages() called by iput(node_inode) will try
>>> to flush node pages. But in this case, we should prevent to do that, since
>>> we will try again from the start.
>>
>> We are protected since we set SBI_POR_DOING flag in sb, so we are safe now?
>
> Safe, but we get an infinite loop to flush node pages.

Got it.

Thanks,

>
>>
>> Thanks,
>
> .
>