From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938550AbcIWVrh (ORCPT ); Fri, 23 Sep 2016 17:47:37 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34298 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933405AbcIWVrc (ORCPT ); Fri, 23 Sep 2016 17:47:32 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 17FBA61258 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Fri, 23 Sep 2016 14:47:30 -0700 From: Stephen Boyd To: Marcin Wojtas Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, mturquette@baylibre.com, sebastian.hesselbarth@gmail.com, andrew@lunn.ch, jason@lakedaemon.net, thomas.petazzoni@free-electrons.com, gregory.clement@free-electrons.com, nadavh@marvell.com, alior@marvell.com, tn@semihalf.com, jaz@semihalf.com Subject: Re: [PATCH v3 3/3] clk: mvebu: migrate CP110 system controller to clk_hw API and registration Message-ID: <20160923214730.GF21232@codeaurora.org> References: <1474448759-24482-1-git-send-email-mw@semihalf.com> <1474448759-24482-4-git-send-email-mw@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474448759-24482-4-git-send-email-mw@semihalf.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/21, Marcin Wojtas wrote: > @@ -203,80 +202,75 @@ static int cp110_syscon_clk_probe(struct platform_device *pdev) > if (ret) > return ret; > > - cp110_clks = devm_kcalloc(&pdev->dev, sizeof(struct clk *), > - CP110_CLK_NUM, GFP_KERNEL); > - if (!cp110_clks) > - return -ENOMEM; > - > - cp110_clk_data = devm_kzalloc(&pdev->dev, > - sizeof(*cp110_clk_data), > + cp110_clk_data = devm_kcalloc(&pdev->dev, sizeof(*cp110_clk_data), > + sizeof(struct clk_hw *) * CP110_CLK_NUM, > GFP_KERNEL); This doesn't look right. Why are calloc()ing clk_hw_onecell_data this way? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project