From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759327AbcIXAPm (ORCPT ); Fri, 23 Sep 2016 20:15:42 -0400 Received: from mail.kernel.org ([198.145.29.136]:37566 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753322AbcIXAPk (ORCPT ); Fri, 23 Sep 2016 20:15:40 -0400 Date: Sat, 24 Sep 2016 09:15:35 +0900 From: Masami Hiramatsu To: Adrian Hunter Cc: Arnaldo Carvalho de Melo , Jiri Olsa , Masami Hiramatsu , Mathieu Poirier , linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/16] perf tools: Increase debug level of SDT debug messages Message-Id: <20160924091535.0be0f371b3242b5552ee2d49@kernel.org> In-Reply-To: <1474641528-18776-9-git-send-email-adrian.hunter@intel.com> References: <1474641528-18776-1-git-send-email-adrian.hunter@intel.com> <1474641528-18776-9-git-send-email-adrian.hunter@intel.com> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 23 Sep 2016 17:38:40 +0300 Adrian Hunter wrote: > Two SDT debug messages can occur for every DSO which is too noisy. > Consequently, increase debug level of SDT messages. OK, but why "4" would you choose? Thanks, > > Signed-off-by: Adrian Hunter > --- > tools/perf/util/build-id.c | 4 ++-- > tools/perf/util/probe-file.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c > index 5651f3c12f93..e528c40739cc 100644 > --- a/tools/perf/util/build-id.c > +++ b/tools/perf/util/build-id.c > @@ -620,7 +620,7 @@ static int build_id_cache__add_sdt_cache(const char *sbuild_id, > > ret = probe_cache__scan_sdt(cache, realname); > if (ret >= 0) { > - pr_debug("Found %d SDTs in %s\n", ret, realname); > + pr_debug4("Found %d SDTs in %s\n", ret, realname); > if (probe_cache__commit(cache) < 0) > ret = -1; > } > @@ -691,7 +691,7 @@ int build_id_cache__add_s(const char *sbuild_id, const char *name, > > /* Update SDT cache : error is just warned */ > if (build_id_cache__add_sdt_cache(sbuild_id, realname) < 0) > - pr_debug("Failed to update/scan SDT cache for %s\n", realname); > + pr_debug4("Failed to update/scan SDT cache for %s\n", realname); > > out_free: > if (!is_kallsyms) > diff --git a/tools/perf/util/probe-file.c b/tools/perf/util/probe-file.c > index 6f931e442f14..436b64731f65 100644 > --- a/tools/perf/util/probe-file.c > +++ b/tools/perf/util/probe-file.c > @@ -699,7 +699,7 @@ int probe_cache__scan_sdt(struct probe_cache *pcache, const char *pathname) > INIT_LIST_HEAD(&sdtlist); > ret = get_sdt_note_list(&sdtlist, pathname); > if (ret < 0) { > - pr_debug("Failed to get sdt note: %d\n", ret); > + pr_debug4("Failed to get sdt note: %d\n", ret); > return ret; > } > list_for_each_entry(note, &sdtlist, note_list) { > -- > 1.9.1 > -- Masami Hiramatsu