From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757584AbcIXMGX convert rfc822-to-8bit (ORCPT ); Sat, 24 Sep 2016 08:06:23 -0400 Received: from einhorn.in-berlin.de ([192.109.42.8]:44114 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750838AbcIXMGT (ORCPT ); Sat, 24 Sep 2016 08:06:19 -0400 X-Envelope-From: stefanr@s5r6.in-berlin.de Date: Sat, 24 Sep 2016 14:06:07 +0200 From: Stefan Richter To: SF Markus Elfring Cc: linux1394-devel@lists.sourceforge.net, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 10/10] firewire-net: Adjust checks for null pointers in five functions Message-ID: <20160924140607.41b782fa@kant> In-Reply-To: <99ff298b-0caa-9f47-d7db-57b6fbd69360@users.sourceforge.net> References: <566ABCD9.1060404@users.sourceforge.net> <99ff298b-0caa-9f47-d7db-57b6fbd69360@users.sourceforge.net> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sep 18 SF Markus Elfring wrote: > The script "checkpatch.pl" can point information out like the following. A side note: checkpatch.pl is for authors to help prepare their submissions of new code (or their refactoring of existing code if for some reason a refactoring is undertaken). > Comparison to NULL could be written !… Yes it could, or it could remain as is. Both styles are used in drivers/firewire/net.c, so it is indeed preferable to normalize it to one of them. I keep your patch for the next occasion when related work is being done on drivers/firewire/net.c or drivers/firewire. > Thus fix the affected source code places. It is not a "fix", it is a stylistic change. > Signed-off-by: Markus Elfring > --- > drivers/firewire/net.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c > index eb7ce5e..e313be3 100644 > --- a/drivers/firewire/net.c > +++ b/drivers/firewire/net.c > @@ -366,13 +366,13 @@ static struct fwnet_partial_datagram *fwnet_pd_new(struct net_device *net, > > INIT_LIST_HEAD(&new->fi_list); > fi = fwnet_frag_new(new, frag_off, frag_len); > - if (fi == NULL) > + if (!fi) > goto free_new; [...] -- Stefan Richter -======----- =--= ==--- http://arcgraph.de/sr/