From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759322AbcIXQjS (ORCPT ); Sat, 24 Sep 2016 12:39:18 -0400 Received: from mail-pa0-f65.google.com ([209.85.220.65]:35685 "EHLO mail-pa0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757348AbcIXQjQ (ORCPT ); Sat, 24 Sep 2016 12:39:16 -0400 Date: Sat, 24 Sep 2016 09:39:12 -0700 From: Dmitry Torokhov To: SF Markus Elfring Cc: Joe Perches , linux-input@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 4/4] Input-gameport: Replace some printk() calls by pr_info() in joydump_connect() Message-ID: <20160924163912.GA40187@dtor-ws> References: <1474733610.23838.2.camel@perches.com> <8164eb48-e3fa-fa9d-6351-f14b595a6dc3@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8164eb48-e3fa-fa9d-6351-f14b595a6dc3@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 24, 2016 at 06:32:29PM +0200, SF Markus Elfring wrote: > >> @@ -57,27 +57,29 @@ static int joydump_connect(struct gameport *gameport, struct gameport_driver *dr > >>> unsigned long flags; > >>> unsigned char u; > >> > >>> - printk(KERN_INFO "joydump: ,------------------ START ----------------.\n"); > >>> - printk(KERN_INFO "joydump: | Dumping: %30s |\n", gameport->phys); > >>> - printk(KERN_INFO "joydump: | Speed: %28d kHz |\n", gameport->speed); > >>> + pr_info(",------------------ START ----------------.\n" > >>> + "| Dumping: %30s |\n" > >>> + "| Speed: %28d kHz |\n", > >>> + gameport->phys, > >>> + gameport->speed); > > > > Not the same output. > > Should the desired output be the same when the relevant data are passed by a single function call > (instead of three as before)? The desired output should not be broken in conversion, which you did. Do you know how syslog works and why the transformation is not correct. I am also curious as to why you are patching joydump? Are you working on extending it? Thanks. -- Dmitry