From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759454AbcIXQlO (ORCPT ); Sat, 24 Sep 2016 12:41:14 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35017 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757348AbcIXQlM (ORCPT ); Sat, 24 Sep 2016 12:41:12 -0400 Date: Sat, 24 Sep 2016 09:41:08 -0700 From: Dmitry Torokhov To: SF Markus Elfring Cc: linux-input@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module "joydump" Message-ID: <20160924164108.GB40187@dtor-ws> References: <3345f7c1-b823-a819-aabf-5b4990068075@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3345f7c1-b823-a819-aabf-5b4990068075@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 24, 2016 at 03:48:54PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 24 Sep 2016 14:30:44 +0200 > > Add a definition for the macro "pr_fmt" so that its information can be used > for consistent message output. > > Signed-off-by: Markus Elfring > --- > drivers/input/joystick/joydump.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/input/joystick/joydump.c b/drivers/input/joystick/joydump.c > index f9f6cbe..a38f10e 100644 > --- a/drivers/input/joystick/joydump.c > +++ b/drivers/input/joystick/joydump.c > @@ -27,6 +27,8 @@ > * Vojtech Pavlik, Simunkova 1594, Prague 8, 182 00 Czech Republic > */ > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > + Why did you split it off from the patch where you attempt to use it? What good does this change do on its own? > #include > #include > #include > -- > 2.10.0 > -- Dmitry