From: Scott Wood <oss@buserror.net>
To: Zhao Qiang <qiang.zhao@nxp.com>
Cc: linuxppc-dev@lists.ozlabs.org, pku.leo@gmail.com,
xiaobo.xie@nxp.com, linux-kernel@vger.kernel.org
Subject: Re: [v6,2/2] QE: remove PPCisms for QE
Date: Sat, 24 Sep 2016 23:19:06 -0500 [thread overview]
Message-ID: <20160925041906.GA16719@home.buserror.net> (raw)
In-Reply-To: <20160925041411.GA16092@home.buserror.net>
On Sat, Sep 24, 2016 at 11:14:11PM -0500, Scott Wood wrote:
> On Fri, Sep 23, 2016 at 10:20:32AM +0800, Zhao Qiang wrote:
> > QE was supported on PowerPC, and dependent on PPC,
> > Now it is supported on other platforms. so remove PPCisms.
> >
> > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > ---
> > Changes for v2:
> > - na
> > Changes for v3:
> > - add NO_IRQ
> > Changes for v4:
> > - modify spin_event_timeout to opencoded timeout loop
> > - remove NO_IRQ
> > - modify virq_to_hw to opencoed code
> > Changes for v5:
> > - modify commit msg
> > - modify depends of QUICC_ENGINE
> > - add kerneldoc header for qe_issue_cmd
> > Changes for v6:
> > - add dependency on FSL_SOC and PPC32 for drivers
> > depending on QUICC_ENGING but not available on ARM
> >
> > drivers/irqchip/qe_ic.c | 28 +++++++-----
> > drivers/net/ethernet/freescale/Kconfig | 10 ++---
> > drivers/soc/fsl/qe/Kconfig | 2 +-
> > drivers/soc/fsl/qe/qe.c | 80 ++++++++++++++++++++--------------
> > drivers/soc/fsl/qe/qe_io.c | 42 ++++++++----------
> > drivers/soc/fsl/qe/qe_tdm.c | 8 ++--
> > drivers/soc/fsl/qe/ucc.c | 10 ++---
> > drivers/soc/fsl/qe/ucc_fast.c | 68 ++++++++++++++---------------
> > drivers/tty/serial/Kconfig | 2 +-
> > drivers/usb/gadget/udc/Kconfig | 2 +-
> > drivers/usb/host/Kconfig | 2 +-
> > include/soc/fsl/qe/qe.h | 1 -
> > include/soc/fsl/qe/qe_ic.h | 12 ++---
> > 13 files changed, 141 insertions(+), 126 deletions(-)
>
> I assume this means you'll be updating
> http://patchwork.ozlabs.org/patch/654473/
> to be based on top of this...
Apparently that assumption was wrong, since I now see that you're
patching drivers/irqchip/qe_ic.c rather than drivers/soc/fsl/qe/qe_ic.c.
Please keep the drivers/irqchip stuff separate and send to the
appropriate maintainers.
-Scott
next prev parent reply other threads:[~2016-09-25 4:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 2:20 [PATCH v6 1/2] qe: modify get_qe_base function Zhao Qiang
2016-09-23 2:20 ` [PATCH v6 2/2] QE: remove PPCisms for QE Zhao Qiang
2016-09-25 4:14 ` [v6,2/2] " Scott Wood
2016-09-25 4:19 ` Scott Wood [this message]
2016-09-26 1:46 ` Qiang Zhao
2016-09-26 23:11 ` Scott Wood
2016-09-27 3:13 ` Qiang Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160925041906.GA16719@home.buserror.net \
--to=oss@buserror.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=pku.leo@gmail.com \
--cc=qiang.zhao@nxp.com \
--cc=xiaobo.xie@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox