From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752880AbcIYFJA (ORCPT ); Sun, 25 Sep 2016 01:09:00 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:39012 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751039AbcIYFI7 (ORCPT ); Sun, 25 Sep 2016 01:08:59 -0400 X-Sasl-enc: 1iv4Ti1E31eZ6gJP6iFODJIu+g/4il71bFGa4BdpE8Oy 1474780136 Date: Sun, 25 Sep 2016 08:08:55 +0300 From: Ido Schimmel To: Colin King Cc: Hariprasad S , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][V2] mlxsw: spectrum: remove redundant check if err is zero Message-ID: <20160925050855.GA4050@splinter> References: <20160925010338.2734-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160925010338.2734-1-colin.king@canonical.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 24, 2016 at 06:03:38PM -0700, Colin King wrote: > From: Colin Ian King > > There is an earlier check and return if err is non-zero, so > the check to see if it is zero is redundant in every iteration > of the loop and hence the check can be removed. > > Signed-off-by: Colin Ian King The subject and commit message are wrong. I think you copy-pasted them from an earlier patch. > --- > drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c > index 2a61617..1073673 100644 > --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c > +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c > @@ -117,11 +117,11 @@ static int validate_filter(struct net_device *dev, > return 0; > } > > -static unsigned int get_filter_steerq(struct net_device *dev, > - struct ch_filter_specification *fs) > +static int get_filter_steerq(struct net_device *dev, > + struct ch_filter_specification *fs) > { > struct adapter *adapter = netdev2adap(dev); > - unsigned int iq; > + int iq; > > /* If the user has requested steering matching Ingress Packets > * to a specific Queue Set, we need to make sure it's in range > @@ -443,10 +443,10 @@ int __cxgb4_set_filter(struct net_device *dev, int filter_id, > struct filter_ctx *ctx) > { > struct adapter *adapter = netdev2adap(dev); > - unsigned int max_fidx, fidx, iq; > + unsigned int max_fidx, fidx; > struct filter_entry *f; > u32 iconf; > - int ret; > + int iq, ret; > > max_fidx = adapter->tids.nftids; > if (filter_id != (max_fidx + adapter->tids.nsftids - 1) && > -- > 2.9.3 >