public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <oss@buserror.net>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Zhao Qiang <qiang.zhao@nxp.com>,
	"David S. Miller" <davem@davemloft.net>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [v2] soc: fsl/qe: fix Oops on CPM1 (and likely CPM2)
Date: Sun, 25 Sep 2016 01:04:01 -0500	[thread overview]
Message-ID: <20160925060401.GA30936@home.buserror.net> (raw)
In-Reply-To: <20160816062620.41D9C1A2456@localhost.localdomain>

On Tue, Aug 16, 2016 at 08:26:20AM +0200, Christophe Leroy wrote:
> fixes: 0e6e01ff694ee ("CPM/QE: use genalloc to manage CPM/QE muram")
> Cc: stable@vger.linux.org
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
[snip]
>  	muram_pbase = of_translate_address(np, zero);
>  	if (muram_pbase == (phys_addr_t)OF_BAD_ADDR) {
> -		pr_err("Cannot translate zero through CPM muram node");
> +		pr_err("Cannot translate zero through CPM/QE muram node");
>  		ret = -ENODEV;
>  		goto out_pool;
>  	}
> @@ -83,14 +88,14 @@ int cpm_muram_init(void)
>  		ret = gen_pool_add(muram_pool, r.start - muram_pbase +
>  				   GENPOOL_OFFSET, resource_size(&r), -1);
>  		if (ret) {
> -			pr_err("QE: couldn't add muram to pool!\n");
> +			pr_err("CPM/QE: couldn't add muram to pool!\n");
>  			goto out_pool;
>  		}
>  	}
>  
>  	muram_vbase = ioremap(muram_pbase, max - muram_pbase + 1);
>  	if (!muram_vbase) {
> -		pr_err("Cannot map QE muram");
> +		pr_err("Cannot map CPM/QE muram");
>  		ret = -ENOMEM;
>  		goto out_pool;
>  	}

These string changes are not related to the bugfix.  Particularly since
this is aimed at stable, I'm removing this part of the patch when
applying.

-Scott

           reply	other threads:[~2016-09-25  6:04 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20160816062620.41D9C1A2456@localhost.localdomain>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160925060401.GA30936@home.buserror.net \
    --to=oss@buserror.net \
    --cc=benh@kernel.crashing.org \
    --cc=christophe.leroy@c-s.fr \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=qiang.zhao@nxp.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox