From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965934AbcIYKei (ORCPT ); Sun, 25 Sep 2016 06:34:38 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41032 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750727AbcIYKeg (ORCPT ); Sun, 25 Sep 2016 06:34:36 -0400 Date: Sun, 25 Sep 2016 12:34:39 +0200 From: Greg KH To: Marcel Xubuntu Cc: wsa@the-dreams.de, linux-kernel@vger.kernel.org Subject: Re: Fwd: Re: Patchwork [1/1] staging: ks7010: Attempt to structure and format to standards Message-ID: <20160925103439.GA8119@kroah.com> References: <4865f87e-83ca-62af-1ff6-63f10e3e6da7@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 24, 2016 at 06:08:34PM +0200, Marcel Xubuntu wrote: > > Code formatting and structuring. > > Signed-off-by: Marcel Ricquier > > --- > > Tested-by: Marcel Ricquier > > Mostly code formatting, unapologetically a stepping stone for a potential > refactoring with a knowledge seeking, following complete disclosure, > ultimate goal. > In case this fails, my backup plan is to have the world's record for the > quickest kernel patch dismissal, either way it's a win. Did I win ?! Why did you repeat this? > diff --git a/drivers/staging/ks7010/ks7010_sdio.c > b/drivers/staging/ks7010/ks7010_sdio.c > index b7337fd..8de2713 100644 > --- a/drivers/staging/ks7010/ks7010_sdio.c > +++ b/drivers/staging/ks7010/ks7010_sdio.c > @@ -14,7 +14,7 @@ > #include > #include > #include > -#include > +#include Patch is corrupted and can not be applied :( Also, you didn't read the link I provided in the last review, please do so and fix up the patch to only do one type of a thing at a time. (hint, "fix all checkpatch issues" is not one thing...) thanks, greg k-h