From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966500AbcIYVCY (ORCPT ); Sun, 25 Sep 2016 17:02:24 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35776 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966064AbcIYVCW (ORCPT ); Sun, 25 Sep 2016 17:02:22 -0400 Date: Sun, 25 Sep 2016 23:02:18 +0200 From: Daniel Vetter To: Baoyou Xie Cc: airlied@linux.ie, ykk@rock-chips.com, inki.dae@samsung.com, seanpaul@chromium.org, gustavo.padovan@collabora.co.uk, daniel.vetter@ffwll.ch, ville.syrjala@linux.intel.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn Subject: Re: [PATCH] drm: bridge: analogix/dp: mark symbols static where possible Message-ID: <20160925210218.GT20761@phenom.ffwll.local> Mail-Followup-To: Baoyou Xie , airlied@linux.ie, ykk@rock-chips.com, inki.dae@samsung.com, seanpaul@chromium.org, gustavo.padovan@collabora.co.uk, ville.syrjala@linux.intel.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn References: <1474788764-6069-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474788764-6069-1-git-send-email-baoyou.xie@linaro.org> X-Operating-System: Linux phenom 4.6.0-1-amd64 User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 25, 2016 at 03:32:44PM +0800, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1053:5: warning: no previous prototype for 'analogix_dp_get_modes' [-Wmissing-prototypes] > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1097:1: warning: no previous prototype for 'analogix_dp_detect' [-Wmissing-prototypes] > > In fact, both functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > So this patch marks both functions with 'static'. > > Signed-off-by: Baoyou Xie This and your drm/bochs patch applied to drm-misc, thanks. -Daniel > --- > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > index efac8ab..e6f7290 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > @@ -1050,7 +1050,7 @@ out: > return ret; > } > > -int analogix_dp_get_modes(struct drm_connector *connector) > +static int analogix_dp_get_modes(struct drm_connector *connector) > { > struct analogix_dp_device *dp = to_dp(connector); > struct edid *edid = (struct edid *)dp->edid; > @@ -1093,7 +1093,7 @@ static const struct drm_connector_helper_funcs analogix_dp_connector_helper_func > .best_encoder = analogix_dp_best_encoder, > }; > > -enum drm_connector_status > +static enum drm_connector_status > analogix_dp_detect(struct drm_connector *connector, bool force) > { > struct analogix_dp_device *dp = to_dp(connector); > -- > 2.7.4 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch