From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1034784AbcIYXfa (ORCPT <rfc822;w@1wt.eu>);
        Sun, 25 Sep 2016 19:35:30 -0400
Received: from mout.kundenserver.de ([212.227.126.135]:50433 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1034674AbcIYXf2 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 25 Sep 2016 19:35:28 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Baoyou Xie <baoyou.xie@linaro.org>
Subject: Re: [PATCH 3/6] isdn/hisax: add function declarations
Date: Mon, 26 Sep 2016 01:26:41 +0200
User-Agent: KMail/1.12.2 (Linux/4.7.0-rc7+; KDE/4.3.2; x86_64; ; )
Cc: isdn@linux-pingi.de, linux-kernel.bfrz@manchmal.in-ulm.de,
        davem@davemloft.net, Network Development <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        xie.baoyou@zte.com.cn
References: <1474694507-7379-1-git-send-email-baoyou.xie@linaro.org> <19682404.Wm2acsDIf0@wuerfel> <CA+DQWkxE_az1C1sZ9Tjqjsgm+-E5bbdNJ_REeH6qXvPdA8JuFQ@mail.gmail.com>
In-Reply-To: <CA+DQWkxE_az1C1sZ9Tjqjsgm+-E5bbdNJ_REeH6qXvPdA8JuFQ@mail.gmail.com>
MIME-Version: 1.0
Message-Id: <201609260126.42034.arnd@arndb.de>
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:naD3KA8K22gLr3QCUH11xdVwMqSWjAB9RA+OGOsJpZbIqwYUMnD
 SVYa1kjuQlJKJaZP6Z9Dp4UDtt5KWcu2pzS2y73CYFBuhXhEXphGWSH9zsxtpq1g6WgozSZ
 gNj5iog/MJR+S0+mOHG/y08F+J8q/woaSCP+dUFgb8txGhlch1SrcYcdW16yR7waO2xfo2c
 IONxuwXK1l481TymhCM6w==
X-UI-Out-Filterresults: notjunk:1;V01:K0:Kda0FyD/sSE=:/iTkKsTSDZZNE8tKB53m5s
 9dxS/J84JnEvYBUYTRlv/sFoophI4+vR/r9gmGfW68wFz4LAdHQ7je4pppUzZ1uwP4DU0ppYF
 fh128/tBXJlqr6BdIpLCdEF62qQVkG0Wx+DAOnXHjxdE33/4/ayKQaBwOtREEw+TW2/eSROg/
 o8tsDOwI2hkRoZhZbNZMu/T8gEMqHO19b8FqFBkIGPY7r9+e5F7TkSaSG4MH3K4QI6MZFprRS
 aEmnLYOlX8IRwWr8uZkmXMtPY5raW/FZ7j6EUwDQrz4yL0VcNNAlyBHnZG1vyzyT8V4LcYtNu
 uK9tK4jxuMa6V7LPZ51sesR0BFLsKiybM0wxVxpUxoeW+4isHVtGmECimrJYCaVStxo8l41St
 ivUzUdTGUO5OqmlNLzmTGJQZ2sk6i+hxwVN5sBNk0yK13vkLs8Ib168L0pqE5e/rCBZpl54cP
 ZkGSX/0CDjt4J24TIEaBFFgGqF3RcpskN1LBwpB7QX5ycWRGARyMIpNk+vaLMxjRLjMK3G90B
 xzc/Ym3grkTCQEZxJ/HtD7gV5ICVRlSJ2PEjD3+Uns6ueid8COCMgfF4T9PHkKVIahqTcp3xh
 hJocWZ0Bd5tGXLslbogM+cJi0XnvlraFyXKtLDUP4yHNFO0xRdyWoIcjvOiN4KtFMyeDsgWgs
 26zrTk7DNMnPBpPEX1eDWN4P7dfKz7lYFEvdPk73lbT+48r7ZloNfMfr2nBForY9kaOXv9Sv3
 r9KW3m9K8Pyt+X8mXlGPgnePRJsmguh7m8JA8w==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sunday 25 September 2016, Baoyou Xie wrote:
> > > @@ -1350,3 +1350,63 @@ static inline struct pci_dev
> > *hisax_find_pci_device(unsigned int vendor,
> > >  }
> > >
> > >  #endif
> > > +
> > > +#if CARD_TELES3
> > > +int setup_teles3(struct IsdnCard *card);
> > > +#endif
> > > +
> > > +#if CARD_TELESPCI
> > > +int setup_telespci(struct IsdnCard *card);
> > > +#endif
> > > +
> >
> > When you add the declarations here, just leave out the #if guards,
> > and put all the declarations here unconditionally, as we normally
> > do in the kernel.
> >
> > oh, in this case, we can leave the declarations out the  #if guards.
> but I suggest we don't do that still, cause of some declarations used by
> function parameters may reply on the macro.

They all have the same 'struct IsdnCard' argument, which is already
visible (otherwise none of them would work).

	Arnd