From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@kernel.org, tglx@linutronix.de, juri.lelli@arm.com,
xlpang@redhat.com, bigeasy@linutronix.de,
linux-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com,
jdesfossez@efficios.com, bristot@redhat.com,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH -v2 3/9] sched/deadline/rtmutex: Dont miss the dl_runtime/dl_period update
Date: Mon, 26 Sep 2016 12:03:29 -0400 [thread overview]
Message-ID: <20160926120329.5221e5cd@grimm.local.home> (raw)
In-Reply-To: <20160926124127.999595184@infradead.org>
On Mon, 26 Sep 2016 14:32:16 +0200
Peter Zijlstra <peterz@infradead.org> wrote:
> Currently dl tasks will actually return at the very beginning
> of rt_mutex_adjust_prio_chain() in !detect_deadlock cases:
>
> if (waiter->prio == task->prio) {
> if (!detect_deadlock)
> goto out_unlock_pi; // out here
> else
> requeue = false;
> }
>
> As the deadline value of blocked deadline tasks(waiters) without
> changing their sched_class(thus prio doesn't change) never changes,
> this seems reasonable, but it actually misses the chance of updating
> rt_mutex_waiter's "dl_runtime(period)_copy" if a waiter updates its
> deadline parameters(dl_runtime, dl_period) or boosted waiter changes
> to !deadline class.
>
> Thus, force deadline task not out by adding the !dl_prio() condition.
>
> Cc: Steven Rostedt <rostedt@goodmis.org>
Acked-by: Steven Rostedt <rostedt@goodmis.org.
-- Steve
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Juri Lelli <juri.lelli@arm.com>
> Signed-off-by: Xunlei Pang <xlpang@redhat.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Link: http://lkml.kernel.org/r/1460633827-345-7-git-send-email-xlpang@redhat.com
next prev parent reply other threads:[~2016-09-26 16:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 12:32 [PATCH -v2 0/9] PI and assorted failings Peter Zijlstra
2016-09-26 12:32 ` [PATCH -v2 1/9] rtmutex: Deboost before waking up the top waiter Peter Zijlstra
2016-09-26 15:15 ` Steven Rostedt
2016-09-26 15:22 ` Peter Zijlstra
2016-09-26 15:35 ` Steven Rostedt
2016-09-26 15:37 ` Steven Rostedt
2016-09-26 15:41 ` Peter Zijlstra
2016-09-29 14:43 ` Thomas Gleixner
2016-09-29 14:49 ` Peter Zijlstra
2016-09-26 15:39 ` Peter Zijlstra
2016-09-28 9:07 ` Sebastian Andrzej Siewior
2016-09-28 9:24 ` Peter Zijlstra
2016-09-26 12:32 ` [PATCH -v2 2/9] sched/rtmutex/deadline: Fix a PI crash for deadline tasks Peter Zijlstra
2016-09-26 15:20 ` Steven Rostedt
2016-09-26 15:26 ` Peter Zijlstra
2016-09-29 14:49 ` Thomas Gleixner
2016-09-26 12:32 ` [PATCH -v2 3/9] sched/deadline/rtmutex: Dont miss the dl_runtime/dl_period update Peter Zijlstra
2016-09-26 16:03 ` Steven Rostedt [this message]
2016-09-29 14:48 ` Thomas Gleixner
2016-09-26 12:32 ` [PATCH -v2 4/9] rtmutex: Remove rt_mutex_fastunlock() Peter Zijlstra
2016-09-29 14:47 ` Thomas Gleixner
2016-09-26 12:32 ` [PATCH -v2 5/9] rtmutex: Clean up Peter Zijlstra
2016-09-26 16:09 ` Steven Rostedt
2016-09-29 14:51 ` Thomas Gleixner
2016-09-26 12:32 ` [PATCH -v2 6/9] sched/rtmutex: Refactor rt_mutex_setprio() Peter Zijlstra
2016-09-26 16:57 ` Steven Rostedt
2016-09-26 12:32 ` [PATCH -v2 7/9] sched,tracing: Update trace_sched_pi_setprio() Peter Zijlstra
2016-09-26 17:04 ` Steven Rostedt
2016-09-27 7:44 ` Peter Zijlstra
2016-09-26 12:32 ` [PATCH -v2 8/9] rtmutex: Fix PI chain order integrity Peter Zijlstra
2016-09-26 12:32 ` [PATCH -v2 9/9] rtmutex: Fix more prio comparisons Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160926120329.5221e5cd@grimm.local.home \
--to=rostedt@goodmis.org \
--cc=bigeasy@linutronix.de \
--cc=bristot@redhat.com \
--cc=jdesfossez@efficios.com \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=xlpang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox