From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941512AbcIZQHk (ORCPT ); Mon, 26 Sep 2016 12:07:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57088 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753549AbcIZQHi (ORCPT ); Mon, 26 Sep 2016 12:07:38 -0400 Date: Mon, 26 Sep 2016 18:07:24 +0200 From: Oleg Nesterov To: Al Viro Cc: Dave Chinner , Jan Kara , Nikolay Borisov , "Paul E. McKenney" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/2] (Was: BUG_ON in rcu_sync_func triggered) Message-ID: <20160926160724.GA6739@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 26 Sep 2016 16:07:27 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, The patches do not depend on each other. 1/2 is the trivial fix, imo -stable material. The bug is very old it seems, but today this race (leading to unbalanced unlock) manifests itself via mysterious BUG_ON's in rcu/sync.c. 2/2 is old, I forgot to send it before. It was already reviewed by Dave and Jan, but the generic/068 test from xfstests triggered the warning. This was fixed by dbad7c993053 "xfs: stop holding ILOCK over filldir callbacks" so we can hopefully kill the early-lockdep-release kludge. Oleg. fs/super.c | 43 ++++++++++++++++++++++++++++--------------- 1 file changed, 28 insertions(+), 15 deletions(-)