From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S966236AbcIZVds (ORCPT <rfc822;w@1wt.eu>);
        Mon, 26 Sep 2016 17:33:48 -0400
Received: from foss.arm.com ([217.140.101.70]:38698 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S965507AbcIZVdq (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 26 Sep 2016 17:33:46 -0400
Date: Mon, 26 Sep 2016 22:33:40 +0100
From: Mark Rutland <mark.rutland@arm.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Eric Dumazet <edumazet@google.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Ingo Molnar <mingo@kernel.org>, Jiri Slaby <jslaby@suse.com>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 0/3] Kill off show_stack() NULL-implies-current idiom
Message-ID: <20160926213340.GA4137@remoulade>
References: <1474902979-18436-1-git-send-email-mark.rutland@arm.com>
 <20160926200136.sbltg4tp5uft4yfo@treble>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160926200136.sbltg4tp5uft4yfo@treble>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Sep 26, 2016 at 03:01:36PM -0500, Josh Poimboeuf wrote:
> On Mon, Sep 26, 2016 at 04:16:16PM +0100, Mark Rutland wrote:
> > Today, show_stack() accepts a NULL task parameter, which it takes to mean the
> > current task. However, as noted in tip/x86/asm commit:
> > 
> >   81539169f283329f ("x86/dumpstack: Remove NULL task pointer convention")
> > 
> > ... having a NULL task parameter imply current leads to subtle bugs in stack
> > walking code (so far seen on both 86 and arm64), makes callsites harder to
> > read, and is unnecessary as all callers have access to current.
> > 
> > As a step towards removing the problematic NULL-implies-current idiom entirely,
> > these patches ensure that generic code explictly passes current to
> > show_stack(), rather than relying on arch code to handle NULL.
> 
> This is a good step, though it would be really nice to fix this
> tree-wide.  Do you have any plans to do so?

FWIW, I completely agree, though I have no plans to do so currently.

I'd meant to Cc linux-arch for this series in order to make people aware,
though evidently I did not. I can Cc subsequent arm64 NULL-implies-current
cleanup patches there, if that's helpful?

> Regardless, for the series:
> 
> Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>

Cheers!

Thanks,
Mark.