From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755211AbcIZXOI (ORCPT ); Mon, 26 Sep 2016 19:14:08 -0400 Received: from mail.kernel.org ([198.145.29.136]:48276 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752733AbcIZXN7 (ORCPT ); Mon, 26 Sep 2016 19:13:59 -0400 Date: Mon, 26 Sep 2016 16:13:54 -0700 From: Shaohua Li To: Gayatri Kammela Cc: linux-raid@vger.kerenl.org, linux-kernel@vger.kernel.org, ravi.v.shankar@intel.com, fenghua.yu@intel.com, "H . Peter Anvin" , Yu-cheng Yu Subject: Re: [PATCH v2] raid6/test/test.c: bug fix: Specify aligned(alignment) attributes to the char arrays Message-ID: <20160926231354.GA98739@kernel.org> References: <1474925858-24409-1-git-send-email-gayatri.kammela@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474925858-24409-1-git-send-email-gayatri.kammela@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 26, 2016 at 02:37:38PM -0700, Gayatri Kammela wrote: > Specifying the aligned attributes to the char data[NDISKS][PAGE_SIZE], > char recovi[PAGE_SIZE] and char recovi[PAGE_SIZE] arrays, so that all > malloc memory is page boundary aligned. > > Without these alignment attributes, the test causes a segfault in > userspace when the NDISKS are changed to 4 from 16. > > The RAID stripes will be page aligned anyway, so we want to test what > the kernel actually will execute. Applied, thanks!