From: Al Viro <viro@ZenIV.linux.org.uk>
To: Miklos Szeredi <mszeredi@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/11] splice cleanups
Date: Tue, 27 Sep 2016 04:55:22 +0100 [thread overview]
Message-ID: <20160927035522.GJ19539@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1473842236-28655-1-git-send-email-mszeredi@redhat.com>
On Wed, Sep 14, 2016 at 10:37:05AM +0200, Miklos Szeredi wrote:
> This contains assorted cleanups in the splice area:
>
> - add helpers for pipe buf ops instead of directly calling them
>
> - page cache buf doesn't seem to need confirming (since ages)
>
> - generic_file_splice_read() and generic_file_read() have lots of
> duplication
>
> Git tree is here:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git#splice
My apologies for not replying back when it had been first posted, especially
since I'd been actively messing with splice-related code at that time
(it started in "xfs_file_splice_read: possible circular locking dependency
detected" thread on xfs list). I've no objections against your inline
helpers. I'm not so sure about ->confirm() and I really think that
__generic_file_splice_read() should simply die.
Could you rebase the beginning of that thing on top of #work.splice_read
in vfs.git?
prev parent reply other threads:[~2016-09-27 3:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 8:37 [PATCH 00/11] splice cleanups Miklos Szeredi
2016-09-14 8:37 ` [PATCH 01/11] pipe: add pipe_buf_get() helper Miklos Szeredi
2016-09-14 8:37 ` [PATCH 02/11] pipe: add pipe_buf_release() helper Miklos Szeredi
2016-09-14 8:37 ` [PATCH 03/11] pipe: add pipe_buf_confirm() helper Miklos Szeredi
2016-09-14 8:37 ` [PATCH 04/11] pipe: add pipe_buf_steal() helper Miklos Szeredi
2016-09-14 8:37 ` [PATCH 05/11] pipe: fix comment in pipe_buf_operations Miklos Szeredi
2016-09-14 8:37 ` [PATCH 06/11] pipe: no need to confirm page cache buf Miklos Szeredi
2016-09-27 3:40 ` Al Viro
2016-09-27 7:34 ` Miklos Szeredi
2016-09-14 8:37 ` [PATCH 07/11] pipe: remove generic_pipe_buf_confirm() Miklos Szeredi
2016-09-16 11:23 ` Christoph Hellwig
2016-09-14 8:37 ` [PATCH 08/11] filemap: add get_page_for_read() helper Miklos Szeredi
2016-09-27 3:43 ` Al Viro
2016-09-14 8:37 ` [PATCH 09/11] splice: use get_page_for_read() Miklos Szeredi
2016-09-27 3:45 ` Al Viro
2016-09-14 8:37 ` [PATCH 10/11] splice: don't check i_size in generic_file_splice_read() Miklos Szeredi
2016-09-14 8:37 ` [PATCH 11/11] splice: fold __generic_file_splice_read() into caller Miklos Szeredi
2016-09-14 8:55 ` [PATCH 00/11] splice cleanups Cedric Blancher
2016-09-14 9:30 ` Miklos Szeredi
2016-09-16 11:24 ` Christoph Hellwig
2016-09-27 3:55 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927035522.GJ19539@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mszeredi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox