From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752831AbcI0HOY (ORCPT <rfc822;w@1wt.eu>);
        Tue, 27 Sep 2016 03:14:24 -0400
Received: from ipmail07.adl2.internode.on.net ([150.101.137.131]:20548 "EHLO
        ipmail07.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751077AbcI0HOQ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 27 Sep 2016 03:14:16 -0400
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A2AULACaG+pXEJqYLHldGwEBAQMBAQEJAQEBgz8BAQEBAR6BU4J6g3mcSgEBAgEBBo0Khh+EFYYYBAICgWVNAQIBAQEBAQIGAQEBAQEBAQE3QIRiAQEEJxMcIxAIAw4KCSUPBSUDBxoTiEzADwEBAQEBBQEBAQEjHoVPhR6Hc4IvAQSZdo9gj3ZIjCODfYNuHBiBSiw0hlcBAQE
Date: Tue, 27 Sep 2016 17:14:04 +1000
From: Dave Chinner <david@fromorbit.com>
To: Jan Kara <jack@suse.cz>
Cc: Oleg Nesterov <oleg@redhat.com>, Al Viro <viro@zeniv.linux.org.uk>,
        Nikolay Borisov <kernel@kyup.com>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()
 and thaw_super() paths
Message-ID: <20160927071404.GA9806@dastard>
References: <20160926160724.GA6739@redhat.com>
 <20160926160806.GB6748@redhat.com>
 <20160926161856.GB32458@quack2.suse.cz>
 <20160926165525.GA9338@redhat.com>
 <20160927065135.GA1139@quack2.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160927065135.GA1139@quack2.suse.cz>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 27, 2016 at 08:51:35AM +0200, Jan Kara wrote:
> On Mon 26-09-16 18:55:25, Oleg Nesterov wrote:
> > On 09/26, Jan Kara wrote:
> > >
> > > On Mon 26-09-16 18:08:06, Oleg Nesterov wrote:
> > > > +/*
> > > > + * Tell lockdep we are holding these locks before we call ->unfreeze_fs(sb).
> > > > + */
> > > > +static void sb_freeze_acquire(struct super_block *sb)
> > >
> > > Can we call this lockdep_sb_freeze_acquire() or something like that so that
> > > it is clear this is only about lockdep annotations? Similarly with
> > > sb_freeze_unlock()...
> > 
> > OK, thanks, done. See V2 below.
> > 
> > > and I hope you really tested
> > > there are no more lockdep false positives ;).
> > 
> > Heh ;) if only I knew how to test this... I ran the following script
> > under qemu
> > 
> > 	mkfs.xfs -f /dev/vda
> > 	mkfs.xfs -f /dev/vdb
> > 
> > 	mkdir -p TEST SCRATCH
> > 
> > 	TEST_DEV=/dev/vda TEST_DIR=TEST SCRATCH_DEV=/dev/vdb SCRATCH_MNT=SCRATCH \
> > 	./check `grep -il freeze tests/*/???`
> 
> You can run either:
> 
> 	./check -g freeze
> 
> to check just the freezing tests or
> 
> 	./check

Better for regression testing is:

check -g auto

so that is skips all the tests that are broken or likely to crash
the machine on some debug check.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com