From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754879AbcI0OAq (ORCPT ); Tue, 27 Sep 2016 10:00:46 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:36920 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751631AbcI0OAl (ORCPT ); Tue, 27 Sep 2016 10:00:41 -0400 Date: Tue, 27 Sep 2016 16:00:44 +0200 From: Greg KH To: Amir Levy Cc: andreas.noever@gmail.com, bhelgaas@google.com, corbet@lwn.net, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, mario_limonciello@dell.com, thunderbolt-linux@intel.com, mika.westerberg@intel.com, tomas.winkler@intel.com, xiong.y.zhang@intel.com Subject: Re: [PATCH v7 3/8] thunderbolt: Kconfig for Thunderbolt Networking Message-ID: <20160927140044.GA21133@kroah.com> References: <1474983821-2313-1-git-send-email-amir.jer.levy@intel.com> <1474983821-2313-4-git-send-email-amir.jer.levy@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474983821-2313-4-git-send-email-amir.jer.levy@intel.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 27, 2016 at 04:43:36PM +0300, Amir Levy wrote: > Update to the Kconfig Thunderbolt description to add > Thunderbolt networking as an option. > The menu item "Thunderbolt support" now offers: > "Apple Hardware Support" (existing) > and/or > "Thunderbolt Networking" (new) > > You can choose the driver for your platform or build both drivers - > each driver will detect if it can run on the specific platform. > If the Thunderbolt Networking option is chosen, Thunderbolt Networking > will be enabled between Linux non-Apple systems, macOS and > Windows based systems. > Thunderbolt Networking will not affect any other Thunderbolt feature that > was previous available to Linux users on either Apple or > non-Apple platforms. > > Signed-off-by: Amir Levy > --- > drivers/thunderbolt/Kconfig | 27 +++++++++++++++++++++++---- > drivers/thunderbolt/Makefile | 2 +- > 2 files changed, 24 insertions(+), 5 deletions(-) > > diff --git a/drivers/thunderbolt/Kconfig b/drivers/thunderbolt/Kconfig > index c121acc..376e5bb 100644 > --- a/drivers/thunderbolt/Kconfig > +++ b/drivers/thunderbolt/Kconfig > @@ -1,13 +1,32 @@ > -menuconfig THUNDERBOLT > - tristate "Thunderbolt support for Apple devices" > +config THUNDERBOLT > + tristate "Thunderbolt support" > depends on PCI > select CRC32 > help > - Cactus Ridge Thunderbolt Controller driver > + Thunderbolt Controller driver > + > +if THUNDERBOLT > + > +config THUNDERBOLT_APPLE > + tristate "Apple hardware support" > + help > This driver is required if you want to hotplug Thunderbolt devices on > Apple hardware. > > Device chaining is currently not supported. > > - To compile this driver a module, choose M here. The module will be > + To compile this driver as a module, choose M here. The module will be > called thunderbolt. > + > +config THUNDERBOLT_ICM You are adding a config option here that is not used in the tree yet. Please wait until you need the option to actually add it :) You might just want to do the APPLE stuff here, that way you can drop in the networking stuff in a simple patch at the end of this series. thanks, greg k-h