From: Sam Ravnborg <sam@ravnborg.org>
To: Babu Moger <babu.moger@oracle.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
mingo@redhat.com, akpm@linux-foundation.org,
keescook@chromium.org, dan.j.williams@intel.com,
aryabinin@virtuozzo.com, tj@kernel.org,
linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH v2 1/2] config: Add new CONFIG_PROVE_LOCKING_SMALL
Date: Tue, 27 Sep 2016 17:43:39 +0200 [thread overview]
Message-ID: <20160927154339.GA32499@ravnborg.org> (raw)
In-Reply-To: <a46631c4-a25f-88b7-9ab5-5e6733c63f51@oracle.com>
On Tue, Sep 27, 2016 at 09:51:40AM -0500, Babu Moger wrote:
>
> On 9/27/2016 6:40 AM, Peter Zijlstra wrote:
> >On Tue, Sep 27, 2016 at 06:46:25AM +0200, Sam Ravnborg wrote:
> >>Since this is only relevant for sparc, and for sparc this is "select"ed,
> >>then there is limited/no gain having this as a visible menu config option.
> >>
> >>How about adding just a simple non-visible config symbol:
> >>
> >>config PROVE_LOCKING_SMALL
> >> bool
> >>
> >>The nice help text can be added to the H file, and the select
> >>can be move to the sparc/Kconfig file where it really belongs.
> >Yes, this should not be user selectable. I don't mind the help being
> >here though.
> How about this?
> Moved everything to arch/sparc/Kconfig.debug. It may be not useful
> to have help in
> config file as it is not visible. Lets have some explanation in .h file.
> I will send v3 version if you all agree.
> =====================================
> diff --git a/arch/sparc/Kconfig.debug b/arch/sparc/Kconfig.debug
> index 6db35fb..67e58a1 100644
> --- a/arch/sparc/Kconfig.debug
> +++ b/arch/sparc/Kconfig.debug
> @@ -21,4 +21,9 @@ config FRAME_POINTER
> depends on MCOUNT
> default y
>
> +config PROVE_LOCKING_SMALL
> + bool
> + depends on PROVE_LOCKING && SPARC
> + default y
> +
> endmenu
The idea is to have the SPAC specific stuff in arch/sparc/Kconfig,
and not scattered in Kconfig files all over the tree.
Therefore drop the "depends".
In sparc/Kconfig you then just do:
config SPARC
select PROVE_LOCKING_SMALL if PROVE_LOCKING
The if part is likely not needed as PROVE_LOCKING_SMALL will be ignored
unless PROVE_LOCKING is enabled.
Sam
next prev parent reply other threads:[~2016-09-27 15:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 22:31 [PATCH v2 0/2] Ajust lockdep static allocations for sparc Babu Moger
2016-09-26 22:31 ` [PATCH v2 1/2] config: Add new CONFIG_PROVE_LOCKING_SMALL Babu Moger
2016-09-27 4:46 ` Sam Ravnborg
2016-09-27 11:40 ` Peter Zijlstra
2016-09-27 14:51 ` Babu Moger
2016-09-27 15:43 ` Sam Ravnborg [this message]
2016-09-27 16:26 ` Babu Moger
2016-09-26 22:31 ` [PATCH v2 2/2] lockdep: Keep the static allocations small for PROVE_LOCKING_SMALL Babu Moger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927154339.GA32499@ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=babu.moger@oracle.com \
--cc=dan.j.williams@intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sparclinux@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).