From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934047AbcI0Pn4 (ORCPT ); Tue, 27 Sep 2016 11:43:56 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:48295 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933122AbcI0Pnr (ORCPT ); Tue, 27 Sep 2016 11:43:47 -0400 Date: Tue, 27 Sep 2016 17:43:39 +0200 From: Sam Ravnborg To: Babu Moger Cc: Peter Zijlstra , mingo@redhat.com, akpm@linux-foundation.org, keescook@chromium.org, dan.j.williams@intel.com, aryabinin@virtuozzo.com, tj@kernel.org, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v2 1/2] config: Add new CONFIG_PROVE_LOCKING_SMALL Message-ID: <20160927154339.GA32499@ravnborg.org> References: <1474929098-68914-1-git-send-email-babu.moger@oracle.com> <1474929098-68914-2-git-send-email-babu.moger@oracle.com> <20160927044625.GA13264@ravnborg.org> <20160927114009.GM5016@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.2 cv=eqGd9chX c=1 sm=1 tr=0 a=Ij76tQDYWdb01v2+RnYW5w==:117 a=Ij76tQDYWdb01v2+RnYW5w==:17 a=kj9zAlcOel0A:10 a=v5k5Q9W3vH1ZtVQfPnMA:9 a=CjuIK1q_8ugA:10 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 27, 2016 at 09:51:40AM -0500, Babu Moger wrote: > > On 9/27/2016 6:40 AM, Peter Zijlstra wrote: > >On Tue, Sep 27, 2016 at 06:46:25AM +0200, Sam Ravnborg wrote: > >>Since this is only relevant for sparc, and for sparc this is "select"ed, > >>then there is limited/no gain having this as a visible menu config option. > >> > >>How about adding just a simple non-visible config symbol: > >> > >>config PROVE_LOCKING_SMALL > >> bool > >> > >>The nice help text can be added to the H file, and the select > >>can be move to the sparc/Kconfig file where it really belongs. > >Yes, this should not be user selectable. I don't mind the help being > >here though. > How about this? > Moved everything to arch/sparc/Kconfig.debug. It may be not useful > to have help in > config file as it is not visible. Lets have some explanation in .h file. > I will send v3 version if you all agree. > ===================================== > diff --git a/arch/sparc/Kconfig.debug b/arch/sparc/Kconfig.debug > index 6db35fb..67e58a1 100644 > --- a/arch/sparc/Kconfig.debug > +++ b/arch/sparc/Kconfig.debug > @@ -21,4 +21,9 @@ config FRAME_POINTER > depends on MCOUNT > default y > > +config PROVE_LOCKING_SMALL > + bool > + depends on PROVE_LOCKING && SPARC > + default y > + > endmenu The idea is to have the SPAC specific stuff in arch/sparc/Kconfig, and not scattered in Kconfig files all over the tree. Therefore drop the "depends". In sparc/Kconfig you then just do: config SPARC select PROVE_LOCKING_SMALL if PROVE_LOCKING The if part is likely not needed as PROVE_LOCKING_SMALL will be ignored unless PROVE_LOCKING is enabled. Sam