linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] uapi: add missing install of sync_file.h
@ 2016-09-27 14:31 Emilio López
  2016-09-27 16:06 ` Gustavo Padovan
  0 siblings, 1 reply; 3+ messages in thread
From: Emilio López @ 2016-09-27 14:31 UTC (permalink / raw)
  To: sumit.semwal
  Cc: dri-devel, linux-kernel, gustavo.padovan, mpe, Emilio López

As part of the sync framework destaging, the sync_file.h header
was moved, but an entry was not added on Kbuild to install it.
This patch resolves this omission so that "make headers_install"
installs this header.

Fixes: 460bfc41fd52 ("dma-buf/sync_file: de-stage sync_file headers")
Reported-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Emilio López <emilio.lopez@collabora.co.uk>
---

I don't know if this is worth cc'ing stable, the patch has been
there since v4.7. I spotted this while reflecting on Michael's
review[0] on my kselftest series, and he later independently
confirmed so[1].

[0] http://www.spinics.net/lists/linux-kselftest/msg00444.html
[1] http://www.spinics.net/lists/linux-kselftest/msg00457.html

 include/uapi/linux/Kbuild | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/uapi/linux/Kbuild b/include/uapi/linux/Kbuild
index 185f8ea..407ca0d 100644
--- a/include/uapi/linux/Kbuild
+++ b/include/uapi/linux/Kbuild
@@ -396,6 +396,7 @@ header-y += string.h
 header-y += suspend_ioctls.h
 header-y += swab.h
 header-y += synclink.h
+header-y += sync_file.h
 header-y += sysctl.h
 header-y += sysinfo.h
 header-y += target_core_user.h
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] uapi: add missing install of sync_file.h
  2016-09-27 14:31 [PATCH] uapi: add missing install of sync_file.h Emilio López
@ 2016-09-27 16:06 ` Gustavo Padovan
  2016-09-29 13:32   ` Sean Paul
  0 siblings, 1 reply; 3+ messages in thread
From: Gustavo Padovan @ 2016-09-27 16:06 UTC (permalink / raw)
  To: Emilio López; +Cc: sumit.semwal, dri-devel, linux-kernel, mpe

2016-09-27 Emilio López <emilio.lopez@collabora.co.uk>:

> As part of the sync framework destaging, the sync_file.h header
> was moved, but an entry was not added on Kbuild to install it.
> This patch resolves this omission so that "make headers_install"
> installs this header.
> 
> Fixes: 460bfc41fd52 ("dma-buf/sync_file: de-stage sync_file headers")
> Reported-by: Michael Ellerman <mpe@ellerman.id.au>
> Signed-off-by: Emilio López <emilio.lopez@collabora.co.uk>
> ---
> 
> I don't know if this is worth cc'ing stable, the patch has been
> there since v4.7. I spotted this while reflecting on Michael's
> review[0] on my kselftest series, and he later independently
> confirmed so[1].

We still don't have any drivers in the kernel using this, no need
to send this stable or 4.8. drm-misc should be fine. 

> 
> [0] http://www.spinics.net/lists/linux-kselftest/msg00444.html
> [1] http://www.spinics.net/lists/linux-kselftest/msg00457.html
> 
>  include/uapi/linux/Kbuild | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

Gustavo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] uapi: add missing install of sync_file.h
  2016-09-27 16:06 ` Gustavo Padovan
@ 2016-09-29 13:32   ` Sean Paul
  0 siblings, 0 replies; 3+ messages in thread
From: Sean Paul @ 2016-09-29 13:32 UTC (permalink / raw)
  To: Gustavo Padovan
  Cc: Emilio López, Sumit Semwal, dri-devel,
	Linux Kernel Mailing List, mpe

On Tue, Sep 27, 2016 at 12:06 PM, Gustavo Padovan
<gustavo.padovan@collabora.com> wrote:
> 2016-09-27 Emilio López <emilio.lopez@collabora.co.uk>:
>
>> As part of the sync framework destaging, the sync_file.h header
>> was moved, but an entry was not added on Kbuild to install it.
>> This patch resolves this omission so that "make headers_install"
>> installs this header.
>>
>> Fixes: 460bfc41fd52 ("dma-buf/sync_file: de-stage sync_file headers")
>> Reported-by: Michael Ellerman <mpe@ellerman.id.au>
>> Signed-off-by: Emilio López <emilio.lopez@collabora.co.uk>
>> ---
>>
>> I don't know if this is worth cc'ing stable, the patch has been
>> there since v4.7. I spotted this while reflecting on Michael's
>> review[0] on my kselftest series, and he later independently
>> confirmed so[1].
>
> We still don't have any drivers in the kernel using this, no need
> to send this stable or 4.8. drm-misc should be fine.
>

Applied to -misc, thanks

Sean

>>
>> [0] http://www.spinics.net/lists/linux-kselftest/msg00444.html
>> [1] http://www.spinics.net/lists/linux-kselftest/msg00457.html
>>
>>  include/uapi/linux/Kbuild | 1 +
>>  1 file changed, 1 insertion(+)
>
> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>
> Gustavo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-09-29 13:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-27 14:31 [PATCH] uapi: add missing install of sync_file.h Emilio López
2016-09-27 16:06 ` Gustavo Padovan
2016-09-29 13:32   ` Sean Paul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).