From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935040AbcI0QSM (ORCPT <rfc822;w@1wt.eu>);
        Tue, 27 Sep 2016 12:18:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53088 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S934325AbcI0QSE (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 27 Sep 2016 12:18:04 -0400
Date: Tue, 27 Sep 2016 18:17:00 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: Waiman Long <Waiman.Long@hpe.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
        Stas Sergeev <stsp@list.ru>, linux-kernel@vger.kernel.org,
        Scott J Norton <scott.norton@hpe.com>,
        Douglas Hatch <doug.hatch@hpe.com>
Subject: Re: [PATCH v3] signals: Avoid unnecessary taking of
        sighand->siglock
Message-ID: <20160927161659.GB21423@redhat.com>
References: <1474979209-11867-1-git-send-email-Waiman.Long@hpe.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1474979209-11867-1-git-send-email-Waiman.Long@hpe.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 27 Sep 2016 16:18:03 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/27, Waiman Long wrote:
>
> +static inline int sigequalsets(const sigset_t *set1, const sigset_t *set2)
> +{
> +	switch (_NSIG_WORDS) {
> +	case 4:
> +		return	(set1->sig[3] == set2->sig[3]) &&
> +			(set1->sig[2] == set2->sig[2]) &&
> +			(set1->sig[1] == set2->sig[1]) &&
> +			(set1->sig[0] == set2->sig[0]);
> +	case 2:
> +		return	(set1->sig[1] == set2->sig[1]) &&
> +			(set1->sig[0] == set2->sig[0]);
> +	case 1:
> +		return	set1->sig[0] == set2->sig[0];
> +	}
> +	return 0;
> +}
> +

OK, this memcmp-by-hand matches other sig* helpers. Well, perhaps

	default:
		BUILD_BUG();

makes sense too, but I won't insist.

> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -2485,6 +2485,13 @@ void __set_current_blocked(const sigset_t *newset)
>  {
>  	struct task_struct *tsk = current;
>  
> +	/*
> +	 * In case the signal mask hasn't changed, there is nothing we need
> +	 * to do. The current->blocked shouldn't be modified by other task.
> +	 */
> +	if (sigequalsets(&tsk->blocked, newset))
> +		return;
> +

Acked-by: Oleg Nesterov <oleg@redhat.com>