From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935674AbcI0Q7W (ORCPT ); Tue, 27 Sep 2016 12:59:22 -0400 Received: from sender153-mail.zoho.com ([74.201.84.153]:25485 "EHLO sender153-mail.zoho.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755231AbcI0Q7L (ORCPT ); Tue, 27 Sep 2016 12:59:11 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=zapps768; d=zoho.com; h=date:from:to:cc:subject:message-id:references:mime-version:content-type:in-reply-to:user-agent; b=cpS9ks03qCLevDjmvqOjFX69wmPfwjQ47xzlhe16gzWXHVzWsXdRtI3Nc+UXXHN6LFaGuD0WAd4E bBqQIy8/Fv/R0LEie6REX1mo6QejFQeeyuFPO812Knlse/82b5Js Date: Tue, 27 Sep 2016 13:59:03 -0300 From: Martin Alonso To: Joe Perches Cc: forest@alittletooquiet.net, gregkh@linuxfoundation.org, pasteka@kabsi.at, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: vt6656: Add spaces around '+' operator Message-ID: <20160927165901.GA28955@malonso-pc> References: <1474912104-13501-1-git-send-email-martin.alonso@zoho.com> <1474912953.2238.17.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1474912953.2238.17.camel@perches.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 26, 2016 at 11:02:33AM -0700, Joe Perches wrote: > On Mon, 2016-09-26 at 14:48 -0300, Martin Alonso wrote: > > Fix coding style issue "spaces preferred around '+' > > detected by checkpatch.pl in dpc.c file. > [] > > diff --git a/drivers/staging/vt6656/dpc.c b/drivers/staging/vt6656/dpc.c > [] > > @@ -75,8 +75,8 @@ int vnt_rx_data(struct vnt_private *priv, struct vnt_rcb *ptr_rcb, > >   > > >   skb_data = (u8 *)skb->data; > >   > > - rx_sts = skb_data+4; > > - rx_rate = skb_data+5; > > + rx_sts = skb_data + 4; > > + rx_rate = skb_data + 5; > >   > >   /* real Frame Size = USBframe_size -4WbkStatus - 4RxStatus */ > >   /* -8TSF - 4RSR - 4SQ3 - ?Padding */ > > You might as well make rx_rate u8 instead of u8 * > and change the uses of rx_rate. rx_sts isn't used > anywhere at all and could be removed. > I'll send two patches to fix this issues. Regards.