From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755765AbcI0SrF (ORCPT ); Tue, 27 Sep 2016 14:47:05 -0400 Received: from mail-pf0-f172.google.com ([209.85.192.172]:36753 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752092AbcI0Sq5 (ORCPT ); Tue, 27 Sep 2016 14:46:57 -0400 Date: Tue, 27 Sep 2016 19:49:02 +0100 From: Lee Jones To: Baoyou Xie Cc: linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn Subject: Re: [PATCH 1/2] mfd: ab8500-debugfs: add function declaration Message-ID: <20160927184902.GA21388@dell> References: <1474695290-21619-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1474695290-21619-1-git-send-email-baoyou.xie@linaro.org> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 24 Sep 2016, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/mfd/ab8500-debugfs.c:1587:28: warning: no previous prototype for 'suspend_test_wake_cause_interrupt_is_mine' [-Wmissing-prototypes] > > In fact, this function need be declared in a header files. > > So this patch adds function declaration in > include/linux/mfd/abx500/ab8500.h. > > Signed-off-by: Baoyou Xie > --- > include/linux/mfd/abx500/ab8500.h | 1 + > 1 file changed, 1 insertion(+) I already fixed this: https://patchwork.kernel.org/patch/9333097/ > diff --git a/include/linux/mfd/abx500/ab8500.h b/include/linux/mfd/abx500/ab8500.h > index 9475fee..a496120 100644 > --- a/include/linux/mfd/abx500/ab8500.h > +++ b/include/linux/mfd/abx500/ab8500.h > @@ -508,6 +508,7 @@ void ab8500_override_turn_on_stat(u8 mask, u8 set); > extern int prcmu_abb_read(u8 slave, u8 reg, u8 *value, u8 size); > void ab8500_dump_all_banks(struct device *dev); > void ab8500_debug_register_interrupt(int line); > +bool suspend_test_wake_cause_interrupt_is_mine(u32 my_int); > #else > static inline void ab8500_dump_all_banks(struct device *dev) {} > static inline void ab8500_debug_register_interrupt(int line) {} -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog