From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756369AbcI0WQA (ORCPT ); Tue, 27 Sep 2016 18:16:00 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46254 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754030AbcI0WPv (ORCPT ); Tue, 27 Sep 2016 18:15:51 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 857C9616B5 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Tue, 27 Sep 2016 15:15:50 -0700 From: Stephen Boyd To: Christophe JAILLET Cc: gregkh@linuxfoundation.org, bjorn.andersson@sonymobile.com, marc.zyngier@arm.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] spmi: pmic-arb: Return an error code if sanity check fails Message-ID: <20160927221550.GB940@codeaurora.org> References: <1474921486-7560-1-git-send-email-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474921486-7560-1-git-send-email-christophe.jaillet@wanadoo.fr> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/26, Christophe JAILLET wrote: > If the test 'if (channel > 5)' is true, then we will return 'err' which > is known to be 0 at this point. > Return -EINVAL instead. > > Signed-off-by: Christophe JAILLET > --- Reviewed-by: Stephen Boyd Looks right, thanks. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project