From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964981AbcI0X5r (ORCPT ); Tue, 27 Sep 2016 19:57:47 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:34487 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964843AbcI0X53 (ORCPT ); Tue, 27 Sep 2016 19:57:29 -0400 Date: Wed, 28 Sep 2016 00:59:37 +0100 From: Lee Jones To: Charles Keepax Cc: rf@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com Subject: Re: [PATCH 1/2] mfd: arizona: Remove arizona_of_get_named_gpio helper function Message-ID: <20160927235937.GO21388@dell> References: <1474385414-27665-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1474385414-27665-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Sep 2016, Charles Keepax wrote: > This function is only used in a single place and no new users will be > added as all the devices other required GPIOs are already handled. As > such just merge the code back into the calling function. > > Signed-off-by: Charles Keepax > --- > drivers/mfd/arizona-core.c | 27 +++++++-------------------- > include/linux/mfd/arizona/core.h | 3 --- > 2 files changed, 7 insertions(+), 23 deletions(-) > > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c > index 4c18c8e..f466f29 100644 > --- a/drivers/mfd/arizona-core.c > +++ b/drivers/mfd/arizona-core.c > @@ -803,25 +803,6 @@ unsigned long arizona_of_get_type(struct device *dev) > } > EXPORT_SYMBOL_GPL(arizona_of_get_type); > > -int arizona_of_get_named_gpio(struct arizona *arizona, const char *prop, > - bool mandatory) > -{ > - int gpio; > - > - gpio = of_get_named_gpio(arizona->dev->of_node, prop, 0); > - if (gpio < 0) { > - if (mandatory) > - dev_err(arizona->dev, > - "Mandatory DT gpio %s missing/malformed: %d\n", > - prop, gpio); > - > - gpio = 0; > - } > - > - return gpio; > -} > -EXPORT_SYMBOL_GPL(arizona_of_get_named_gpio); > - > static int arizona_of_get_core_pdata(struct arizona *arizona) > { > struct arizona_pdata *pdata = &arizona->pdata; > @@ -831,7 +812,13 @@ static int arizona_of_get_core_pdata(struct arizona *arizona) > int ret, i; > int count = 0; > > - pdata->reset = arizona_of_get_named_gpio(arizona, "wlf,reset", true); > + pdata->reset = of_get_named_gpio(arizona->dev->of_node, "wlf,reset", 0); > + if (pdata->reset < 0) { > + dev_err(arizona->dev, "Reset gpio missing/malformed: %d\n", gpio should be GPIO. I'll probably just fix this up myself though. Applied, thanks. > + pdata->reset); > + > + pdata->reset = 0; > + } > > ret = of_property_read_u32_array(arizona->dev->of_node, > "wlf,gpio-defaults", > diff --git a/include/linux/mfd/arizona/core.h b/include/linux/mfd/arizona/core.h > index b9909bb..b31b3be 100644 > --- a/include/linux/mfd/arizona/core.h > +++ b/include/linux/mfd/arizona/core.h > @@ -191,7 +191,4 @@ int cs47l24_patch(struct arizona *arizona); > int wm8997_patch(struct arizona *arizona); > int wm8998_patch(struct arizona *arizona); > > -extern int arizona_of_get_named_gpio(struct arizona *arizona, const char *prop, > - bool mandatory); > - > #endif -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog