From: Lee Jones <lee.jones@linaro.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: rf@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 2/2] mfd: arizona: Handle probe deferral for reset GPIO
Date: Wed, 28 Sep 2016 00:59:51 +0100 [thread overview]
Message-ID: <20160927235951.GP21388@dell> (raw)
In-Reply-To: <1474385414-27665-2-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On Tue, 20 Sep 2016, Charles Keepax wrote:
> The Arizona CODECs will generally function correctly without a reset line
> although it is strongly advised to have one, as such we do allow the system
> to boot if the reset gpio is missing or incorrectly specified. However
> we should fail probe if we get a probe deferral request, this patch adds
> handling for this case.
>
> Reported-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/arizona-core.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index f466f29..d18f3b1 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -813,7 +813,9 @@ static int arizona_of_get_core_pdata(struct arizona *arizona)
> int count = 0;
>
> pdata->reset = of_get_named_gpio(arizona->dev->of_node, "wlf,reset", 0);
> - if (pdata->reset < 0) {
> + if (pdata->reset == -EPROBE_DEFER) {
> + return pdata->reset;
> + } else if (pdata->reset < 0) {
> dev_err(arizona->dev, "Reset gpio missing/malformed: %d\n",
> pdata->reset);
>
> @@ -1011,11 +1013,14 @@ int arizona_dev_init(struct arizona *arizona)
> dev_set_drvdata(arizona->dev, arizona);
> mutex_init(&arizona->clk_lock);
>
> - if (dev_get_platdata(arizona->dev))
> + if (dev_get_platdata(arizona->dev)) {
> memcpy(&arizona->pdata, dev_get_platdata(arizona->dev),
> sizeof(arizona->pdata));
> - else
> - arizona_of_get_core_pdata(arizona);
> + } else {
> + ret = arizona_of_get_core_pdata(arizona);
> + if (ret < 0)
> + return ret;
> + }
>
> BUILD_BUG_ON(ARRAY_SIZE(arizona->mclk) != ARRAY_SIZE(mclk_name));
> for (i = 0; i < ARRAY_SIZE(arizona->mclk); i++) {
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-09-27 23:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 15:30 [PATCH 1/2] mfd: arizona: Remove arizona_of_get_named_gpio helper function Charles Keepax
2016-09-20 15:30 ` [PATCH 2/2] mfd: arizona: Handle probe deferral for reset GPIO Charles Keepax
2016-09-27 23:59 ` Lee Jones [this message]
2016-09-27 23:59 ` [PATCH 1/2] mfd: arizona: Remove arizona_of_get_named_gpio helper function Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927235951.GP21388@dell \
--to=lee.jones@linaro.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=rf@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox