From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756774AbcI1DIr (ORCPT ); Tue, 27 Sep 2016 23:08:47 -0400 Received: from mga09.intel.com ([134.134.136.24]:12771 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756600AbcI1DIj (ORCPT ); Tue, 27 Sep 2016 23:08:39 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,408,1470726000"; d="scan'208";a="766655615" Date: Wed, 28 Sep 2016 08:47:10 +0530 From: Vinod Koul To: Peter Ujfalusi Cc: dan.j.williams@intel.com, arnd@arndb.de, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tony@atomide.com Subject: Re: [PATCH v3 6/9] dmaengine: ti-dma-crossbar: Fix of_device_id data parameter usage Message-ID: <20160928031709.GJ2467@localhost> References: <20160921124135.11849-1-peter.ujfalusi@ti.com> <20160921124135.11849-7-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160921124135.11849-7-peter.ujfalusi@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 21, 2016 at 03:41:32PM +0300, Peter Ujfalusi wrote: > @@ -395,7 +403,7 @@ static int ti_dra7_xbar_probe(struct platform_device *pdev) > > xbar->dmarouter.dev = &pdev->dev; > xbar->dmarouter.route_free = ti_dra7_xbar_free; > - xbar->dma_offset = (u32)match->data; > + xbar->dma_offset = *(u32*)match->data; ^^^^ we need space between u32 and * > mutex_init(&xbar->mutex); > platform_set_drvdata(pdev, xbar); > @@ -428,7 +436,7 @@ static int ti_dma_xbar_probe(struct platform_device *pdev) > if (unlikely(!match)) > return -EINVAL; > > - switch ((u32)match->data) { > + switch (*(u32*)match->data) { here too please -- ~Vinod