From: Greg KH <gregkh@linuxfoundation.org>
To: Matthew Kilgore <mattkilgore12@gmail.com>
Cc: namrataashettar@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fixes: 3d44a78f0d8b ("staging: rtl8712: Remove unnecessary 'else'")
Date: Wed, 28 Sep 2016 08:10:16 +0200 [thread overview]
Message-ID: <20160928061016.GA2841@kroah.com> (raw)
In-Reply-To: <20160928030754.GA5457@gmail.com>
On Tue, Sep 27, 2016 at 11:07:54PM -0400, Matthew Kilgore wrote:
> An "unnecessary" 'else' was removed due to complains from checkpatch.pl
> as it is preceded by a 'return', however the 'else' branch is necessary
> as an earlier branch of the 'if' falls through. By removing the 'else',
> that route now hits the 'break' and the 'while' loop exits prematurely.
>
> This commit reverts that change and puts the original 'else' back in
> place.
Ugh, good catch, sorry for missing this, my fault.
greg k-h
prev parent reply other threads:[~2016-09-28 6:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 3:07 [PATCH] Fixes: 3d44a78f0d8b ("staging: rtl8712: Remove unnecessary 'else'") Matthew Kilgore
2016-09-28 6:10 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928061016.GA2841@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattkilgore12@gmail.com \
--cc=namrataashettar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox